Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 10824410: [Sync] Refactor passphrase state handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix last test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sync/internal_api/sync_encryption_handler_impl.cc ('K') | « sync/internal_api/sync_manager_impl.cc ('k') | sync/protocol/client_debug_info.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index 022459935d6a3381703a72652d13e448dcc217ec..7c6f30cedfb7de05636d7bce8d98a4ad6f83387f 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -700,6 +700,7 @@ class SyncEncryptionHandlerObserverMock
void(ModelTypeSet, bool)); // NOLINT
MOCK_METHOD0(OnEncryptionComplete, void()); // NOLINT
MOCK_METHOD1(OnCryptographerStateChanged, void(Cryptographer*)); // NOLINT
+ MOCK_METHOD1(OnPassphraseStateChanged, void(PassphraseState)); // NOLINT
};
class SyncNotifierMock : public SyncNotifier {
@@ -1524,6 +1525,8 @@ TEST_F(SyncManagerTest, EncryptDataTypesWithData) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase", true);
EXPECT_TRUE(EncryptEverythingEnabledForTest());
@@ -1564,8 +1567,8 @@ TEST_F(SyncManagerTest, SetInitialGaiaPass) {
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
false);
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1598,8 +1601,8 @@ TEST_F(SyncManagerTest, UpdateGaiaPass) {
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
false);
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1642,11 +1645,13 @@ TEST_F(SyncManagerTest, SetPassphraseWithPassword) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
true);
- EXPECT_TRUE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(CUSTOM_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1698,8 +1703,8 @@ TEST_F(SyncManagerTest, SupplyPendingGAIAPass) {
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
sync_manager_.GetEncryptionHandler()->SetDecryptionPassphrase("passphrase2");
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1754,8 +1759,8 @@ TEST_F(SyncManagerTest, SupplyPendingOldGAIAPass) {
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_gaia",
false);
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
testing::Mock::VerifyAndClearExpectations(&encryption_observer_);
{
@@ -1776,8 +1781,8 @@ TEST_F(SyncManagerTest, SupplyPendingOldGAIAPass) {
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"old_gaia",
false);
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
Cryptographer* cryptographer = trans.GetCryptographer();
@@ -1826,9 +1831,11 @@ TEST_F(SyncManagerTest, SupplyPendingExplicitPass) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetDecryptionPassphrase("explicit");
- EXPECT_TRUE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(CUSTOM_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1870,8 +1877,8 @@ TEST_F(SyncManagerTest, SupplyPendingGAIAPassUserProvided) {
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"passphrase",
false);
- EXPECT_FALSE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(IMPLICIT_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -1899,11 +1906,13 @@ TEST_F(SyncManagerTest, SetPassphraseWithEmptyPasswordNode) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
true);
- EXPECT_TRUE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(CUSTOM_PASSPHRASE,
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_FALSE(EncryptEverythingEnabledForTest());
{
ReadTransaction trans(FROM_HERE, sync_manager_.GetUserShare());
@@ -2122,6 +2131,8 @@ TEST_F(SyncManagerTest, UpdateEntryWithEncryption) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
true);
@@ -2317,11 +2328,13 @@ TEST_F(SyncManagerTest, UpdatePasswordNewPassphrase) {
EXPECT_CALL(encryption_observer_, OnPassphraseAccepted());
EXPECT_CALL(encryption_observer_, OnEncryptionComplete());
EXPECT_CALL(encryption_observer_, OnCryptographerStateChanged(_));
+ EXPECT_CALL(encryption_observer_,
+ OnPassphraseStateChanged(CUSTOM_PASSPHRASE));
sync_manager_.GetEncryptionHandler()->SetEncryptionPassphrase(
"new_passphrase",
true);
- EXPECT_TRUE(
- sync_manager_.GetEncryptionHandler()->IsUsingExplicitPassphrase());
+ EXPECT_EQ(CUSTOM_PASSPHRASE,
akalin 2012/08/22 20:10:39 can you write a test that uses any of the other tw
Nicolas Zea 2012/08/22 20:18:33 Those will be in future CL's once the migration lo
+ sync_manager_.GetEncryptionHandler()->GetPassphraseState());
EXPECT_TRUE(ResetUnsyncedEntry(PASSWORDS, client_tag));
}
« sync/internal_api/sync_encryption_handler_impl.cc ('K') | « sync/internal_api/sync_manager_impl.cc ('k') | sync/protocol/client_debug_info.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698