Issue 10824364: [NOT FOR REVIEW] ash: Add some implementation for the window management extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824364: [NOT FOR REVIEW] ash: Add some implementation for the window management extension API.

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, tfarina, ben+watch_chromium.org, rjkroege

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Add some implementation for the window management extension API. The implementation triggers onWindowCreated, onWindowShown, onWindowHidden, onWindowClosed and onActiveWindowChanged events. BUG=143504

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+465 lines, -8 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/shell.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ash/shell/shell_delegate_impl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/shell/shell_delegate_impl.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/shell_delegate.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ash/test/test_shell_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	ash/wm/window_manager_extension.h	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
A	ash/wm/window_manager_extension.cc	View		1 chunk	+75 lines, -0 lines	0 comments	Download
M	ash/wm/window_util.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	ash/wm/window_util.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A	chrome/browser/extensions/api/wm/wm_utils.h	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/wm/wm_utils.cc	View	1 2	1 chunk	+100 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/ash/window_manager_extension.h	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/ash/window_manager_extension.cc	View	1 2	1 chunk	+81 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_shell_delegate.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_shell_delegate.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sadrul

8 years, 4 months ago (2012-08-17 22:16:31 UTC) #1

Hi! This is a follow-up CL for http://codereview.chromium.org/10855228/

Expand Messages | Collapse Messages