Issue 10824356: Disable leak annotations for NaCl untrusted builds.

Issue 10824356: Disable leak annotations for NaCl untrusted builds. (Closed)

Created:
8 years, 4 months ago by bbudge

Modified:
8 years, 4 months ago

Reviewers:
Alexander Potapenko, brettw

CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org, _com_google_glider

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable leak annotations for NaCl untrusted builds. BUG=116317 TEST=compiles on linux heap checker bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152137

Patch Set 2 : Disable leak annotations for NaCl untrusted builds. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	base/debug/leak_annotations.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

LGTM You may also need someone from the base/ owners to review this. http://codereview.chromium.org/10824356/diff/1/base/debug/leak_annotations.h File ...

8 years, 4 months ago (2012-08-17 17:25:48 UTC) #2

bbudge

brettw for OWNERS review. http://codereview.chromium.org/10824356/diff/1/base/debug/leak_annotations.h File base/debug/leak_annotations.h (right): http://codereview.chromium.org/10824356/diff/1/base/debug/leak_annotations.h#newcode1 base/debug/leak_annotations.h:1: // Copyright (c) 2012 The ...

8 years, 4 months ago (2012-08-17 17:28:27 UTC) #3

bbudge

Disable leak annotations for NaCl untrusted builds. BUG=143421 TEST=compiles, links on heapcheck bots.

8 years, 4 months ago (2012-08-17 17:49:07 UTC) #4

lgtm

Expand Messages | Collapse Messages