Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: net/disk_cache/disk_cache_test_util.h

Issue 10824336: Run the disk cache tests in scoped temporary directories instead of a fixed directory so that they … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/disk_cache_test_util.h
===================================================================
--- net/disk_cache/disk_cache_test_util.h (revision 151735)
+++ net/disk_cache/disk_cache_test_util.h (working copy)
@@ -19,9 +19,6 @@
// Deletes all file son the cache.
bool DeleteCache(const FilePath& path);
-// Gets the path to the cache test folder.
-FilePath GetCacheFilePath();
rvargas (doing something else) 2012/08/16 21:04:19 Still need this (at the very least for stress test
-
// Fills buffer with random values (may contain nulls unless no_nulls is true).
void CacheTestFillBuffer(char* buffer, size_t len, bool no_nulls);
@@ -31,23 +28,6 @@
// Returns true if the cache is not corrupt.
bool CheckCacheIntegrity(const FilePath& path, bool new_eviction, uint32 mask);
-// Helper class which ensures that the cache dir returned by GetCacheFilePath
-// exists and is clear in ctor and that the directory gets deleted in dtor.
-class ScopedTestCache {
- public:
- explicit ScopedTestCache(const FilePath& path);
- // Use a specific folder name.
- explicit ScopedTestCache(const std::string& name);
- ~ScopedTestCache();
-
- FilePath path() const { return path_; }
-
- private:
- const FilePath path_; // Path to the cache test folder.
-
- DISALLOW_COPY_AND_ASSIGN(ScopedTestCache);
-};
-
// -----------------------------------------------------------------------
// Simple helper to deal with the message loop on a test.

Powered by Google App Engine
This is Rietveld 408576698