chrome/browser/resources/options2/chromeos/network_list.js - Issue 10824328: Reduce number of expensive calls to List.redraw() during load of settings page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/chromeos/network_list.js

Issue 10824328: Reduce number of expensive calls to List.redraw() during load of settings page. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressed all comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options2/autofill_edit_address_overlay.js ('k') | chrome/browser/resources/options2/content_settings_exceptions_area.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options2/chromeos/network_list.js

diff --git a/chrome/browser/resources/options2/chromeos/network_list.js b/chrome/browser/resources/options2/chromeos/network_list.js

index 3946216813bc474e19c7df4ffebf098a5e0ce7e3..44088284fed750b670f4b1bb5aca67012e8e6b4c 100644

--- a/chrome/browser/resources/options2/chromeos/network_list.js

+++ b/chrome/browser/resources/options2/chromeos/network_list.js

@@ -728,6 +728,7 @@ cr.define('options.network', function() {

/** @inheritDoc */

decorate: function() {

List.prototype.decorate.call(this);

+ this.startBatchUpdates();

this.autoExpands = true;

this.addEventListener('blur', this.onBlur_);

this.dataModel = new ArrayDataModel([]);

@@ -764,6 +765,7 @@ cr.define('options.network', function() {

function(event) {

enableDataRoaming_ = event.value.value;

});

+ this.endBatchUpdates();

/**

@@ -878,6 +880,7 @@ cr.define('options.network', function() {

NetworkList.refreshNetworkData = function(data) {

var networkList = $('network-list');

+ networkList.startBatchUpdates();

cellularAvailable_ = data.cellularAvailable;

cellularEnabled_ = data.cellularEnabled;

wimaxAvailable_ = data.wimaxAvailable;

@@ -966,6 +969,7 @@ cr.define('options.network', function() {

else

networkList.deleteItem('vpn');

networkList.updateToggleControl('airplaneMode', data.airplaneMode);

+ networkList.endBatchUpdates();

};

/**