Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 10824324: Binary files for Android about:welcome page. (Closed)

Created:
8 years, 4 months ago by newt (away)
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Binary files for Android about:welcome page. This upstreams the images for https://chromiumcodereview.appspot.com/10828140/ BUG=136951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, --2 lines) Patch
A chrome/browser/resources/about_welcome_android/images/holo_logo_150.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/about_welcome_android/images/holo_logo_200.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
newt (away)
8 years, 4 months ago (2012-08-16 00:09:46 UTC) #1
Nico
lgtm You can TBR binary file CLs.
8 years, 4 months ago (2012-08-16 00:11:14 UTC) #2
newt (away)
On 2012/08/16 00:11:14, Nico wrote: > lgtm > > You can TBR binary file CLs. ...
8 years, 4 months ago (2012-08-16 00:14:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10824324/1
8 years, 4 months ago (2012-08-16 00:15:01 UTC) #4
Nico
If you say "TBR=someone", then CQ should be happy with that.
8 years, 4 months ago (2012-08-16 00:18:20 UTC) #5
Nico
On 2012/08/16 00:18:20, Nico wrote: > If you say "TBR=someone", then CQ should be happy ...
8 years, 4 months ago (2012-08-16 00:18:47 UTC) #6
commit-bot: I haz the power
Try job failure for 10824324-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=48134 Step "update" is always ...
8 years, 4 months ago (2012-08-16 00:19:29 UTC) #7
newt (away)
8 years, 4 months ago (2012-08-16 00:19:51 UTC) #8
On 2012/08/16 00:18:47, Nico wrote:
> On 2012/08/16 00:18:20, Nico wrote:
> > If you say "TBR=someone", then CQ should be happy with that.
> 
> …except this is a binary change, so the CQ probably can't land it anyway. So
> just git cl dcommit.

Got it now.  Thanks for the explanations.

Powered by Google App Engine
This is Rietveld 408576698