Adding unit test to check for incorrect mouse enter/exit event handling

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/point.h"
@@ skipping 53 matching lines @@
 // relevant platforms.
 #if defined(USE_AURA)
 typedef NativeWidgetCapture NativeWidgetPlatformForTest;
 #elif defined(OS_WIN)
 typedef NativeWidgetWin NativeWidgetPlatformForTest;
 #endif
 
 // A view that always processes all mouse events.
 class MouseView : public View {
  public:
-  MouseView() : View() {
+  MouseView()
+      : View(),
+        entered_(0),
+        exited_(0) {
   }
   virtual ~MouseView() {}
 
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE {
     return true;
   }
+
+  virtual void OnMouseEntered(const ui::MouseEvent& event) OVERRIDE {
+    entered_++;
+  }
+
+  virtual void OnMouseExited(const ui::MouseEvent& event) OVERRIDE {
+    exited_++;
+  }
+
+  // Return the number of OnMouseEntered calls and reset the counter.
+  int CheckEnteredCalls() {

[sky, 2012/08/16 00:38:15]

Can you remove Check from the name of these methods since they don't actually
check anything.

[Mr4D (OOO till 08-26), 2012/08/16 16:04:17]

Done.

+    int i = entered_;
+    entered_ = 0;
+    return i;
+  }
+
+  // Return the number of OnMouseExited calls and reset the counter.
+  int CheckExitedCalls() {
+    int i = exited_;
+    exited_ = 0;
+    return i;
+  }
+
+ private:
+  int entered_;
+  int exited_;
+
+  DISALLOW_COPY_AND_ASSIGN(MouseView);
 };
 
 typedef ViewsTestBase WidgetTest;
 
 NativeWidget* CreatePlatformNativeWidget(
     internal::NativeWidgetDelegate* delegate) {
   return new NativeWidgetPlatformForTest(delegate);
 }
 
 Widget* CreateTopLevelPlatformWidget() {
@@ skipping 153 matching lines @@
   ui::MouseEvent released2(ui::ET_MOUSE_RELEASED, p2, p2,
                            ui::EF_LEFT_MOUSE_BUTTON);
   toplevel->OnMouseEvent(released2);
   EXPECT_FALSE(WidgetHasMouseCapture(toplevel));
   EXPECT_FALSE(WidgetHasMouseCapture(child1));
   EXPECT_FALSE(WidgetHasMouseCapture(child2));
 
   toplevel->CloseNow();
 }
 
+// Tests mouse move outside of the window into the "resize controller" and back
+// will still generate an OnMouseEntered and OnMouseExited event..
+TEST_F(WidgetTest, CheckResizeControllerEvents) {
+  Widget* toplevel = CreateTopLevelPlatformWidget();
+
+  toplevel->SetBounds(gfx::Rect(0, 0, 100, 100));
+
+  MouseView* view = new MouseView();
+  view->SetBounds(90, 90, 10, 10);
+  toplevel->GetRootView()->AddChildView(view);
+
+  toplevel->Show();
+  RunPendingMessages();
+
+  // Move to an outside position.
+  gfx::Point p1(200, 200);
+  ui::MouseEvent moved_out(ui::ET_MOUSE_MOVED, p1, p1, ui::EF_NONE);
+  toplevel->OnMouseEvent(moved_out);
+  EXPECT_EQ(0, view->CheckEnteredCalls());
+  EXPECT_EQ(0, view->CheckExitedCalls());
+
+  // Move onto the active view.
+  gfx::Point p2(95, 95);
+  ui::MouseEvent moved_over(ui::ET_MOUSE_MOVED, p2, p2, ui::EF_NONE);
+  toplevel->OnMouseEvent(moved_over);
+  EXPECT_EQ(1, view->CheckEnteredCalls());
+  EXPECT_EQ(0, view->CheckExitedCalls());
+
+  // Move onto the outer resizing border.
+  gfx::Point p3(102, 95);
+  ui::MouseEvent moved_resizer(ui::ET_MOUSE_MOVED, p3, p3, ui::EF_NONE);
+  toplevel->OnMouseEvent(moved_resizer);
+  EXPECT_EQ(0, view->CheckEnteredCalls());
+  EXPECT_EQ(1, view->CheckExitedCalls());
+
+  // Move onto the view again.
+  toplevel->OnMouseEvent(moved_over);
+  EXPECT_EQ(1, view->CheckEnteredCalls());
+  EXPECT_EQ(0, view->CheckExitedCalls());
+
+  RunPendingMessages();
+
+  toplevel->CloseNow();
+}
+
 // Test if a focus manager and an inputmethod work without CHECK failure
 // when window activation changes.
 TEST_F(WidgetTest, ChangeActivation) {
   Widget* top1 = CreateTopLevelPlatformWidget();
   // CreateInputMethod before activated
   top1->GetInputMethod();
   top1->Show();
   RunPendingMessages();
 
   Widget* top2 = CreateTopLevelPlatformWidget();
@@ skipping 557 matching lines @@
   // And it stays maximized after getting out of full screen.
   EXPECT_EQ(ui::SHOW_STATE_MAXIMIZED, GetWidgetShowState(toplevel));
 
   // Clean up.
   toplevel->Close();
   RunPendingMessages();
 }
 
 }  // namespace
 }  // namespace views