Fix DaemonControllerLinux::SetConfigAndStart() to reload config automatically.

Fix DaemonControllerLinux::SetConfigAndStart() to reload config automatically.

Also fixed several issues with managing chromoting from the webapp. Now it is
possible to start the app and change PIN.

BUG=120950
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151969

[Jamie, 2012-08-13 23:44:30]

Daemon controller LGTM. I'll let Lambros do a more detailed review of the
Python, since he's more familiar with it.

http://codereview.chromium.org/10824286/diff/4001/remoting/host/host_config.h
File remoting/host/host_config.h (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/host/host_config.h...
remoting/host/host_config.h:69: // that all other values are still copied.
s/that all/that case, all/?

http://codereview.chromium.org/10824286/diff/4001/remoting/host/in_memory_hos...
File remoting/host/in_memory_host_config.cc (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/host/in_memory_hos...
remoting/host/in_memory_host_config.cc:56: } else if
(dictionary->GetBoolean(*key, &bool_value)) {
The code this is based on didn't handle Boolean values. This is undoubtedly
better, but was there a bug in the old code we should be aware of?

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:164: # consider config to be valid in this
case.
I'm not a Python expert--I take it .get doesn't throw but the []-operator does?

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:773: logging.error("Auth tokens are not
configured.")
In a previous comment, you state that we can use either xmpp or oauth. Here
you're failing if there's no xmpp token. Is this correct?

[Lambros, 2012-08-14 01:07:44]

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:164: # consider config to be valid in this
case.
On 2012/08/13 23:44:31, Jamie wrote:
> I'm not a Python expert--I take it .get doesn't throw but the []-operator
does?

That is correct, get(key) returns None if the key isn't in the dictionary.

Please could you expand the comment to explain why we want to consider the
config to be valid (even if the oauth or xmpp_auth token is missing)?

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:678: action="store_true", help="Reload the
config.")
Clarify: "Reload the config of the currently-running host."

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:773: logging.error("Auth tokens are not
configured.")
On 2012/08/13 23:44:31, Jamie wrote:
> In a previous comment, you state that we can use either xmpp or oauth. Here
> you're failing if there's no xmpp token. Is this correct?
+1 It's not clear to me what's going on here.  The Authentication.load_config()
method was originally written to return True or False, based on whether the
config had sufficient keys to run the host, or whether we needed the user to
type in credentials.  If we keep that original meaning, we shouldn't need extra
checks here.

[Sergey Ulanov, 2012-08-14 18:00:37]

http://codereview.chromium.org/10824286/diff/4001/remoting/host/host_config.h
File remoting/host/host_config.h (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/host/host_config.h...
remoting/host/host_config.h:69: // that all other values are still copied.
On 2012/08/13 23:44:31, Jamie wrote:
> s/that all/that case, all/?

Done.

http://codereview.chromium.org/10824286/diff/4001/remoting/host/in_memory_hos...
File remoting/host/in_memory_host_config.cc (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/host/in_memory_hos...
remoting/host/in_memory_host_config.cc:56: } else if
(dictionary->GetBoolean(*key, &bool_value)) {
On 2012/08/13 23:44:31, Jamie wrote:
> The code this is based on didn't handle Boolean values. This is undoubtedly
> better, but was there a bug in the old code we should be aware of?

We use boolean only for oauth_use_official_client_id parameter. That parameter
is specified when host is started, but not when the config is updated. It was
breaking the code we had for linux, but on mac only update was affected by this
issue, so it was still working fine on mac.

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:164: # consider config to be valid in this
case.
On 2012/08/14 01:07:44, Lambros wrote:
> On 2012/08/13 23:44:31, Jamie wrote:
> > I'm not a Python expert--I take it .get doesn't throw but the []-operator
> does?
> 
> That is correct, get(key) returns None if the key isn't in the dictionary.
> 
> Please could you expand the comment to explain why we want to consider the
> config to be valid (even if the oauth or xmpp_auth token is missing)?

Done.

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:773: logging.error("Auth tokens are not
configured.")
On 2012/08/14 01:07:44, Lambros wrote:
> On 2012/08/13 23:44:31, Jamie wrote:
> > In a previous comment, you state that we can use either xmpp or oauth. Here
> > you're failing if there's no xmpp token. Is this correct?
> +1 It's not clear to me what's going on here.  The
Authentication.load_config()
> method was originally written to return True or False, based on whether the
> config had sufficient keys to run the host, or whether we needed the user to
> type in credentials.  If we keep that original meaning, we shouldn't need
extra
> checks here.

The host needs tokens to authenticate XMPP connection, but doesn't need auth
token for the directory API. When the config is generated by the webapp it
doesn't have chromoting_auth_token so previously load_config() would fail even
though host would still work with it. I updated documentation for load_config()
to make it clear what's meaning of the result.

http://codereview.chromium.org/10824286/diff/4001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:773: logging.error("Auth tokens are not
configured.")
On 2012/08/13 23:44:31, Jamie wrote:
> In a previous comment, you state that we can use either xmpp or oauth. Here
> you're failing if there's no xmpp token. Is this correct?

has_xmpp_token() returns true if we have any types of auth tokens that can be
used to authenticate XMPP connection. It can be either GTalk auth token that
this script gets via ClientAuth (stored in the config as xmpp_auth_token) or
oauth refresh token (stored as oauth_refresh_token).
I see how it can be confusing. Renamed the method to has_xmpp_credentials() and
added comments

[Lambros, 2012-08-15 20:25:57]

Python LGTM with style nits.

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:191: 
nit: two blank lines between top-levels
(http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank_...)

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:790: not auth_config_loaded or not
auth.has_chromoting_credentials()
nit: Use round brackets instead of backslash
(http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_l...)

[Sergey Ulanov, 2012-08-16 00:52:45]

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:191: 
On 2012/08/15 20:25:58, Lambros wrote:
> nit: two blank lines between top-levels
>
(http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Blank_...)

Done.

http://codereview.chromium.org/10824286/diff/9001/remoting/tools/me2me_virtua...
remoting/tools/me2me_virtual_host.py:790: not auth_config_loaded or not
auth.has_chromoting_credentials()
On 2012/08/15 20:25:58, Lambros wrote:
> nit: Use round brackets instead of backslash
>
(http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_l...)

Done.

[commit-bot: I haz the power, 2012-08-16 00:53:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10824286/8002

[commit-bot: I haz the power, 2012-08-16 01:13:29]

Try job failure for 10824286-8002 (retry) on mac for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2012-08-16 01:16:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10824286/2004

[commit-bot: I haz the power, 2012-08-16 04:01:28]

Try job failure for 10824286-2004 (retry) on win_rel for step
"interactive_ui_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...