Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10824272: Add a skeleton gamepad resource. (Closed)

Created:
8 years, 4 months ago by brettw
Modified:
8 years, 4 months ago
Reviewers:
raymes
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add a skeleton gamepad resource. This implements the skeleton of the gamepad resource for the IPC proxy. It is not actually hooked up. Hooking it up will require moving some gamepad lock code to a shared location. This also hooks up the browser message routing for implementing resource hosts in the browser process. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153265

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -40 lines) Patch
M content/browser/ppapi_plugin_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc View 2 chunks +17 lines, -1 line 0 comments Download
A content/browser/renderer_host/pepper/pepper_gamepad_host.h View 1 2 3 1 chunk +37 lines, -0 lines 1 comment Download
A content/browser/renderer_host/pepper/pepper_gamepad_host.cc View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/host/dispatch_host_message.h View 1 chunk +20 lines, -12 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/proxy/gamepad_resource.h View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A ppapi/proxy/gamepad_resource.cc View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 3 2 chunks +15 lines, -3 lines 0 comments Download
A ppapi/thunk/ppb_gamepad_api.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_gamepad_thunk.cc View 1 2 2 chunks +12 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 3 5 chunks +15 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 3 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
8 years, 4 months ago (2012-08-22 22:09:38 UTC) #1
raymes
My guess is that you don't want to call into the in-process implementation from the ...
8 years, 4 months ago (2012-08-23 15:52:32 UTC) #2
brettw
This is a synchronous API so we need to have the data in shared memory. ...
8 years, 4 months ago (2012-08-23 21:22:28 UTC) #3
raymes
8 years, 4 months ago (2012-08-23 21:56:11 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698