Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4361)

Unified Diff: chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc

Issue 10824232: Add systeminfo.storage API implementation skeleton (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Capitalize systeminfo.storage to systemInfo.storage Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc
diff --git a/chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc b/chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bc8385ac03bf7fedd6c94aa95385c7f06590abf2
--- /dev/null
+++ b/chrome/browser/extensions/api/system_info_storage/storage_info_provider.cc
@@ -0,0 +1,13 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// // Use of this source code is governed by a BSD-style license that can be
+// // found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/system_info_storage/storage_info_provider.h"
Mihai Parparita -not on Chrome 2012/08/14 00:07:31 For the sake of brevity, you may want to start wit
Hongbo Min 2012/08/14 01:37:23 If the namespace specified in IDL is systemInfo.X,
Hongbo Min 2012/08/14 04:25:57 If using JSON format, all systemInfo API could be
Mihai Parparita -not on Chrome 2012/08/15 00:14:05 It's not worth switching to the JSON format just f
Hongbo Min 2012/08/15 13:43:07 The bug is filed at http://crbug.com/142841
+
+namespace extensions {
+namespace systeminfo {
+const char kStorageTypeUnknown[] = "unknown";
+const char kStorageTypeHardDisk[] = "harddisk";
+const char kStorageTypeRemovable[] = "removable";
+} // namespace systeminfo
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698