remoting/host/usage_stats_consent_win.cc - Issue 10824166: Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/usage_stats_consent_win.cc

Issue 10824166: Cleaned up usage of std::wstring in src/remoting. Added presubmit warning supressions for the reman… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/host/usage_stats_consent_win.cc

diff --git a/remoting/host/usage_stats_consent_win.cc b/remoting/host/usage_stats_consent_win.cc

index cefb1cf2beaccc5119ed4e5076e3f3fcb31d4275..f0d0a1dc5f9a63a26b521ded2e7ffd3362eb4201 100644

--- a/remoting/host/usage_stats_consent_win.cc

+++ b/remoting/host/usage_stats_consent_win.cc

@@ -24,6 +24,7 @@ const wchar_t kOmahaClientStateMedium[] = L"ClientStateMedium";

const wchar_t kOmahaUsagestatsValue[] = L"usagestats";

LONG ReadUsageStatsValue(const wchar_t* state_key, DWORD* usagestats_out) {

+ // presubmit: allow wstring

std::wstring client_state = StringPrintf(kOmahaClientStateKeyFormat,

state_key,

remoting::kHostOmahaAppid);

Wez 2012/08/06 18:33:18 Here.

alexeypa (please no reviews) 2012/08/06 19:31:54 RegKey's using wchar_t.

@@ -71,6 +72,7 @@ bool IsUsageStatsAllowed() {

bool SetUsageStatsConsent(bool allowed) {

DWORD value = allowed;

+ // presubmit: allow wstring

std::wstring client_state = StringPrintf(kOmahaClientStateKeyFormat,

kOmahaClientStateMedium,

kHostOmahaAppid);

Wez 2012/08/06 18:33:18 Here.

alexeypa (please no reviews) 2012/08/06 19:31:54 RegKey's using wchar_t

« remoting/host/policy_hack/policy_watcher_win.cc ('K') | « remoting/host/policy_hack/policy_watcher_win.cc ('k') | remoting/host/win/host_service.h » ('j') | no next file with comments »