[Sync] Avoid unregistering object IDs on shutdown

sync/internal_api/sync_manager_impl_unittest.cc

Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index bd2ffeff0ad07d9f90775a906c44fdbf12e7fc7d..88717be08d4b2bca56aa9f7e8488a55e47117cde 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -696,8 +696,9 @@ class SyncManagerObserverMock : public SyncManager::Observer {
 
 class SyncNotifierMock : public SyncNotifier {
  public:
+  MOCK_METHOD2(SetHandler, void(const std::string&, SyncNotifierObserver*));
   MOCK_METHOD2(UpdateRegisteredIds,
-               void(SyncNotifierObserver*, const ObjectIdSet&));
+               void(const std::string&, const ObjectIdSet&));
   MOCK_METHOD1(SetUniqueId, void(const std::string&));
   MOCK_METHOD1(SetStateDeprecated, void(const std::string&));
   MOCK_METHOD2(UpdateCredentials,
@@ -742,6 +743,8 @@ class SyncManagerTest : public testing::Test,
     EXPECT_CALL(*sync_notifier_mock_, SetStateDeprecated(""));
     EXPECT_CALL(*sync_notifier_mock_,
                 UpdateCredentials(credentials.email, credentials.sync_token));
+    EXPECT_CALL(*sync_notifier_mock_, SetHandler("SyncManagerImpl", _))
+        .Times(2);
 
     sync_manager_.AddObserver(&observer_);
     EXPECT_CALL(observer_, OnInitializationComplete(_, _, _)).
@@ -782,7 +785,6 @@ class SyncManagerTest : public testing::Test,
 
   void TearDown() {
     sync_manager_.RemoveObserver(&observer_);

[msw, 2012/08/07 20:09:30]

If you want to ensure that UpdateRegisteredIds(_, ObjectIdSet()) isn't called,
please restore the EXPECT_CALL with .Times(0).

-    EXPECT_CALL(*sync_notifier_mock_, UpdateRegisteredIds(_, ObjectIdSet()));
     sync_manager_.ShutdownOnSyncThread();
     sync_notifier_mock_ = NULL;
     PumpLoop();
@@ -956,16 +958,24 @@ TEST_F(SyncManagerTest, UpdateEnabledTypes) {
   ModelSafeRoutingInfo routes;
   GetModelSafeRoutingInfo(&routes);
   const ModelTypeSet enabled_types = GetRoutingInfoTypes(routes);
-
   EXPECT_CALL(*sync_notifier_mock_,
               UpdateRegisteredIds(
                   _, ModelTypeSetToObjectIdSet(enabled_types)));
+
   sync_manager_.UpdateEnabledTypes(enabled_types);
 }
 
+TEST_F(SyncManagerTest, SetInvalidationHandler) {
+  const char kHandlerName[] = "handler";

[msw, 2012/08/07 20:09:30]

nit: move this to an anon namespace to share with
UpdateRegisteredInvalidationIds (and future similar tests).

[akalin, 2012/08/07 23:38:05]

this'll be rendered moot

[akalin, 2012/08/07 23:38:05]

moot

+  EXPECT_CALL(*sync_notifier_mock_, SetHandler(kHandlerName, NULL));
+  sync_manager_.SetInvalidationHandler(kHandlerName, NULL);
+}
+
 TEST_F(SyncManagerTest, UpdateRegisteredInvalidationIds) {
-  EXPECT_CALL(*sync_notifier_mock_, UpdateRegisteredIds(NULL, ObjectIdSet()));
-  sync_manager_.UpdateRegisteredInvalidationIds(NULL, ObjectIdSet());
+  const char kHandlerName[] = "handler";
+  EXPECT_CALL(*sync_notifier_mock_,
+              UpdateRegisteredIds(kHandlerName, ObjectIdSet()));
+  sync_manager_.UpdateRegisteredInvalidationIds(kHandlerName, ObjectIdSet());
 }
 
 TEST_F(SyncManagerTest, ProcessJsMessage) {