Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/internal_api/public/sync_manager.h

Issue 10824161: [Sync] Avoid unregistering object IDs on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/sync/profile_sync_service.h ('K') | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | sync/internal_api/public/test/fake_sync_manager.h » ('j') | sync/internal_api/public/test/fake_sync_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/sync_manager.h
diff --git a/sync/internal_api/public/sync_manager.h b/sync/internal_api/public/sync_manager.h
index f36b8ec8b49e1752976fc2849acfc134f9a85bf7..cf49e928ab575cf316b3416784828d0fa0d123d9 100644
--- a/sync/internal_api/public/sync_manager.h
+++ b/sync/internal_api/public/sync_manager.h
@@ -407,9 +407,14 @@ class SyncManager {
const ModelTypeSet& enabled_types) = 0;
// Forwards to the underlying notifier (see
+ // SyncNotifier::SetHandler()).
msw 2012/08/03 23:30:46 nit: line breaks :)
akalin 2012/08/07 07:25:19 Done.
+ virtual void SetInvalidationHandler(
+ const std::string& handler_name, SyncNotifierObserver* handler) = 0;
msw 2012/08/03 23:30:46 one param per line
akalin 2012/08/07 07:25:19 Done.
+
+ // Forwards to the underlying notifier (see
// SyncNotifier::UpdateRegisteredIds()).
virtual void UpdateRegisteredInvalidationIds(
- SyncNotifierObserver* handler, const ObjectIdSet& ids) = 0;
+ const std::string& handler_name, const ObjectIdSet& ids) = 0;
msw 2012/08/03 23:30:46 one param per line
akalin 2012/08/07 07:25:19 Done.
// Put the syncer in normal mode ready to perform nudges and polls.
virtual void StartSyncingNormally(
« chrome/browser/sync/profile_sync_service.h ('K') | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | sync/internal_api/public/test/fake_sync_manager.h » ('j') | sync/internal_api/public/test/fake_sync_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698