Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: sync/internal_api/public/sync_manager.h

Issue 10824161: [Sync] Avoid unregistering object IDs on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_ 5 #ifndef SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
6 #define SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_ 6 #define SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 virtual bool PurgePartiallySyncedTypes() = 0; 400 virtual bool PurgePartiallySyncedTypes() = 0;
401 401
402 // Update tokens that we're using in Sync. Email must stay the same. 402 // Update tokens that we're using in Sync. Email must stay the same.
403 virtual void UpdateCredentials(const SyncCredentials& credentials) = 0; 403 virtual void UpdateCredentials(const SyncCredentials& credentials) = 0;
404 404
405 // Called when the user disables or enables a sync type. 405 // Called when the user disables or enables a sync type.
406 virtual void UpdateEnabledTypes( 406 virtual void UpdateEnabledTypes(
407 const ModelTypeSet& enabled_types) = 0; 407 const ModelTypeSet& enabled_types) = 0;
408 408
409 // Forwards to the underlying notifier (see 409 // Forwards to the underlying notifier (see
410 // SyncNotifier::SetHandler()).
msw 2012/08/03 23:30:46 nit: line breaks :)
akalin 2012/08/07 07:25:19 Done.
411 virtual void SetInvalidationHandler(
412 const std::string& handler_name, SyncNotifierObserver* handler) = 0;
msw 2012/08/03 23:30:46 one param per line
akalin 2012/08/07 07:25:19 Done.
413
414 // Forwards to the underlying notifier (see
410 // SyncNotifier::UpdateRegisteredIds()). 415 // SyncNotifier::UpdateRegisteredIds()).
411 virtual void UpdateRegisteredInvalidationIds( 416 virtual void UpdateRegisteredInvalidationIds(
412 SyncNotifierObserver* handler, const ObjectIdSet& ids) = 0; 417 const std::string& handler_name, const ObjectIdSet& ids) = 0;
msw 2012/08/03 23:30:46 one param per line
akalin 2012/08/07 07:25:19 Done.
413 418
414 // Put the syncer in normal mode ready to perform nudges and polls. 419 // Put the syncer in normal mode ready to perform nudges and polls.
415 virtual void StartSyncingNormally( 420 virtual void StartSyncingNormally(
416 const ModelSafeRoutingInfo& routing_info) = 0; 421 const ModelSafeRoutingInfo& routing_info) = 0;
417 422
418 // Attempts to re-encrypt encrypted data types using the passphrase provided. 423 // Attempts to re-encrypt encrypted data types using the passphrase provided.
419 // Notifies observers of the result of the operation via OnPassphraseAccepted 424 // Notifies observers of the result of the operation via OnPassphraseAccepted
420 // or OnPassphraseRequired, updates the nigori node, and does re-encryption as 425 // or OnPassphraseRequired, updates the nigori node, and does re-encryption as
421 // appropriate. If an explicit password has been set previously, we drop 426 // appropriate. If an explicit password has been set previously, we drop
422 // subsequent requests to set a passphrase. If the cryptographer has pending 427 // subsequent requests to set a passphrase. If the cryptographer has pending
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 virtual bool ReceivedExperiment(Experiments* experiments) = 0; 525 virtual bool ReceivedExperiment(Experiments* experiments) = 0;
521 526
522 // Uses a read-only transaction to determine if the directory being synced has 527 // Uses a read-only transaction to determine if the directory being synced has
523 // any remaining unsynced items. May be called on any thread. 528 // any remaining unsynced items. May be called on any thread.
524 virtual bool HasUnsyncedItems() = 0; 529 virtual bool HasUnsyncedItems() = 0;
525 }; 530 };
526 531
527 } // namespace syncer 532 } // namespace syncer
528 533
529 #endif // SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_ 534 #endif // SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698