[Sync] Avoid unregistering object IDs on shutdown

chrome/browser/sync/glue/chrome_sync_notification_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_
 #define CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner.h"
@@ skipping 18 matching lines @@
 // each observer's OnIncomingNotification method on these
 // notifications (on the sync task runner).
 class ChromeSyncNotificationBridge : public content::NotificationObserver {
  public:
   // Must be created and destroyed on the UI thread.
   ChromeSyncNotificationBridge(
       const Profile* profile,
       const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner);
   virtual ~ChromeSyncNotificationBridge();
 
+  // Must be called on the UI thread while the sync task runner is

[msw, 2012/08/03 23:30:46]

nit: line breaking; does your IDE show the 80 char guide?

[akalin, 2012/08/07 07:25:19]

Done.

+  // still around.  No other member functions on the sync thread may
+  // be called after this is called.
+  void StopForShutdown();
+
   // Must be called on the sync task runner.
   void UpdateEnabledTypes(syncer::ModelTypeSet enabled_types);
   // Marked virtual for tests.
-  virtual void UpdateRegisteredIds(syncer::SyncNotifierObserver* handler,
+  virtual void SetHandler(const std::string& handler_name,
+                          syncer::SyncNotifierObserver* handler);
+  virtual void UpdateRegisteredIds(const std::string& handler_name,
                                    const syncer::ObjectIdSet& ids);
 
   // NotificationObserver implementation. Called on UI thread.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
  private:
   // Inner class to hold all the bits used on |sync_task_runner_|.
   class Core;
 
   const scoped_refptr<base::SequencedTaskRunner> sync_task_runner_;
 
   // Created on the UI thread, used only on |sync_task_runner_|.
   const scoped_refptr<Core> core_;
 
   // Used only on the UI thread.
   content::NotificationRegistrar registrar_;
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_