Pass tap count (1 or 2) with tap gesture events

Pass tap count (1 or 2) with tap gesture events

This is necessary to support the generation of the correct dblclick event sequence in WebKit.

Remove evil generic_x/generic_y from GestureEventDetails (some event types have data other than floats in that position of the union, this wasn't typesafe).

Adds missing double tap gesture recognizer unit tests.

This makes ET_GESTURE_DOUBLE_TAP pretty pointless now.  I've filed crbug.com/140382 to track removing it.

BUG=115486
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149935

[Rick Byers, 2012-08-03 01:05:58]

Sadrul, please review.  

WebKit side that builds on this (but can be safely submitted independently) is
here: https://bugs.webkit.org/show_bug.cgi?id=92412.  Do you want to review that
too, or should I get rjkroege?

[sadrul, 2012-08-03 01:50:33]

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_win.cc:431: data().deltaX
= details.scale();
I think you need to set velocity for FLING_START

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
File content/browser/renderer_host/web_input_event_aurax11.cc (right):

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
content/browser/renderer_host/web_input_event_aurax11.cc:397: gesture_event.type
= WebKit::WebInputEvent::GestureFlingStart;
I believe deltaX/Y needs to be set to details().velocity_x()/y() here too

http://codereview.chromium.org/10824158/diff/4002/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.h (right):

http://codereview.chromium.org/10824158/diff/4002/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.h:94: Gestures* gestures);
each param should be in its own line

[sadrul, 2012-08-03 01:54:28]

LGTM with the comments addressed

[Rick Byers, 2012-08-03 14:51:53]

Thanks Sadrul.
+sky for OWNERS in content/browser

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_win.cc:431: data().deltaX
= details.scale();
On 2012/08/03 01:50:33, sadrul wrote:
> I think you need to set velocity for FLING_START

Thanks, done.  Also added it to the comments in the WebGestureEvent definition
on the WebKit side since it was missing there.

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
File content/browser/renderer_host/web_input_event_aurax11.cc (right):

http://codereview.chromium.org/10824158/diff/4002/content/browser/renderer_ho...
content/browser/renderer_host/web_input_event_aurax11.cc:397: gesture_event.type
= WebKit::WebInputEvent::GestureFlingStart;
On 2012/08/03 01:50:33, sadrul wrote:
> I believe deltaX/Y needs to be set to details().velocity_x()/y() here too

Done.

http://codereview.chromium.org/10824158/diff/4002/ui/base/gestures/gesture_se...
File ui/base/gestures/gesture_sequence.h (right):

http://codereview.chromium.org/10824158/diff/4002/ui/base/gestures/gesture_se...
ui/base/gestures/gesture_sequence.h:94: Gestures* gestures);
On 2012/08/03 01:50:33, sadrul wrote:
> each param should be in its own line

Done.

[sky, 2012-08-03 17:22:27]

LGTM

[commit-bot: I haz the power, 2012-08-03 19:37:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rbyers@chromium.org/10824158/8002

[commit-bot: I haz the power, 2012-08-03 21:53:38]

Change committed as 149935