Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/system/tray/system_tray_bubble.cc

Issue 10824153: Change Ash web notification behavior (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit tests Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | ash/system/tray/tray_background_view.h » ('j') | ash/system/tray/tray_background_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/system_tray_bubble.cc
diff --git a/ash/system/tray/system_tray_bubble.cc b/ash/system/tray/system_tray_bubble.cc
index 15314c3024c1f236848139e85edef1caabca996a..ef3c293678058d316c467b21b5bf1a6a8b5dd85f 100644
--- a/ash/system/tray/system_tray_bubble.cc
+++ b/ash/system/tray/system_tray_bubble.cc
@@ -279,12 +279,11 @@ void SystemTrayBubble::InitView(views::View* anchor,
if (bubble_type_ == BUBBLE_TYPE_DETAILED &&
init_params.max_height < kDetailedBubbleMaxHeight) {
init_params.max_height = kDetailedBubbleMaxHeight;
+ } else if (bubble_type_ == BUBBLE_TYPE_NOTIFICATION) {
+ init_params.close_on_deactivate = false;
}
-
bubble_view_ = TrayBubbleView::Create(anchor, this, init_params);
- if (bubble_type_ == BUBBLE_TYPE_NOTIFICATION)
- bubble_view_->set_close_on_deactivate(false);
CreateItemViews(login_status);
« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | ash/system/tray/tray_background_view.h » ('j') | ash/system/tray/tray_background_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698