Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 10824153: Change Ash web notification behavior (Closed)

Created:
8 years, 4 months ago by stevenjb
Modified:
8 years, 4 months ago
Reviewers:
sadrul, jennyz
CC:
chromium-reviews, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Change Ash web notification behavior Changes: * A single notification bubble is shown when a new message arrives * The message center is shown when the icon is clicked * Thie icon shows a numeric display instead of the current icons BUG=137155, 137150 TEST=See issues and above for new behavior. In particular test interaction between web notifications . tray and system tray / notifications. TBR=sky@chromium.org (ui/resources) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149810

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Total comments: 2

Patch Set 3 : Rebase + fix comment #

Patch Set 4 : Fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -299 lines) Patch
M ash/system/status_area_widget.h View 2 chunks +8 lines, -9 lines 0 comments Download
M ash/system/status_area_widget.cc View 2 chunks +10 lines, -19 lines 0 comments Download
M ash/system/tray/system_tray.h View 5 chunks +4 lines, -9 lines 0 comments Download
M ash/system/tray/system_tray.cc View 11 chunks +16 lines, -92 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/system/tray/tray_background_view.h View 1 2 3 3 chunks +45 lines, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 4 chunks +98 lines, -2 lines 0 comments Download
M ash/system/tray/tray_bubble_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_bubble_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 4 chunks +21 lines, -21 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 16 chunks +214 lines, -142 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D ui/resources/default_100_percent/ash/statusbar_notifications.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D ui/resources/default_200_percent/ash/statusbar_notifications.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
stevenjb
Ready for review. A lot of this is just moving common code to TrayBackgroundView and ...
8 years, 4 months ago (2012-08-02 21:20:53 UTC) #1
jennyz
lgtm http://codereview.chromium.org/10824153/diff/16/ash/system/tray/tray_background_view.cc File ash/system/tray/tray_background_view.cc (right): http://codereview.chromium.org/10824153/diff/16/ash/system/tray/tray_background_view.cc#newcode22 ash/system/tray/tray_background_view.cc:22: // Adjust the size of SystemTrayContainer with additional ...
8 years, 4 months ago (2012-08-03 00:32:33 UTC) #2
jennyz
lgtm with a small nit.
8 years, 4 months ago (2012-08-03 00:33:11 UTC) #3
stevenjb
http://codereview.chromium.org/10824153/diff/16/ash/system/tray/tray_background_view.cc File ash/system/tray/tray_background_view.cc (right): http://codereview.chromium.org/10824153/diff/16/ash/system/tray/tray_background_view.cc#newcode22 ash/system/tray/tray_background_view.cc:22: // Adjust the size of SystemTrayContainer with additional padding. ...
8 years, 4 months ago (2012-08-03 01:34:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10824153/4002
8 years, 4 months ago (2012-08-03 05:46:20 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 07:36:29 UTC) #6
Change committed as 149810

Powered by Google App Engine
This is Rietveld 408576698