Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: sync/notifier/registration_manager_unittest.cc

Issue 10824140: Add InvalidationStateTracker::Forget() to erase an entry from storage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/registration_manager_unittest.cc
diff --git a/sync/notifier/registration_manager_unittest.cc b/sync/notifier/registration_manager_unittest.cc
index e2b9b91bd5a6f8e884f790fcd2eff14312cc786c..df35d71eed93797d82488afe9de9dcf9a6d4df1c 100644
--- a/sync/notifier/registration_manager_unittest.cc
+++ b/sync/notifier/registration_manager_unittest.cc
@@ -238,13 +238,19 @@ TEST_F(RegistrationManagerTest, SetRegisteredIds) {
EXPECT_TRUE(fake_registration_manager_.GetRegisteredIdsForTest().empty());
EXPECT_TRUE(fake_invalidation_client_.GetRegisteredIdsForTest().empty());
- fake_registration_manager_.SetRegisteredIds(ids);
+ ObjectIdSet expected_unregistered_ids;
+
+ ObjectIdSet unregistered_ids =
+ fake_registration_manager_.SetRegisteredIds(ids);
+ EXPECT_EQ(expected_unregistered_ids, unregistered_ids);
EXPECT_EQ(ids, fake_registration_manager_.GetRegisteredIdsForTest());
EXPECT_EQ(ids, fake_invalidation_client_.GetRegisteredIdsForTest());
ids.insert(GetIdForIndex(kObjectIdsCount - 1));
ids.erase(GetIdForIndex(kObjectIdsCount - 2));
- fake_registration_manager_.SetRegisteredIds(ids);
+ unregistered_ids = fake_registration_manager_.SetRegisteredIds(ids);
+ expected_unregistered_ids.insert(GetIdForIndex(kObjectIdsCount - 2));
+ EXPECT_EQ(expected_unregistered_ids, unregistered_ids);
EXPECT_EQ(ids, fake_registration_manager_.GetRegisteredIdsForTest());
EXPECT_EQ(ids, fake_invalidation_client_.GetRegisteredIdsForTest());
}
« sync/notifier/chrome_invalidation_client.cc ('K') | « sync/notifier/registration_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698