Add logging for shaders that don't compile

gpu/command_buffer/service/program_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/program_manager.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 420 matching lines @@
   glGetShaderiv(info->service_id(), GL_COMPILE_STATUS, &status);
   if (status) {
     info->SetStatus(true, "", translator);
     if (program_cache_) {
       const char* untranslated_source = source ? source->c_str() : "";
       program_cache_->ShaderCompilationSucceeded(untranslated_source);
     }
   } else {
     // We cannot reach here if we are using the shader translator.
     // All invalid shaders must be rejected by the translator.
     // All translated shaders must compile.

[alokp, 2012/07/31 23:04:56]

Could you append "unless the driver is buggy" to this line.

-    LOG_IF(ERROR, translator)
-        << "Shader translator allowed/produced an invalid shader.";
     GLint max_len = 0;
     glGetShaderiv(info->service_id(), GL_INFO_LOG_LENGTH, &max_len);
     scoped_array<char> temp(new char[max_len]);
     GLint len = 0;
     glGetShaderInfoLog(info->service_id(), max_len, &len, temp.get());
     DCHECK(max_len == 0 || len < max_len);
     DCHECK(len == 0 || temp[len] == '\0');
     info->SetStatus(false, std::string(temp.get(), len).c_str(), NULL);
+    LOG_IF(ERROR, translator)
+        << "Shader translator allowed/produced an invalid shader:"
+        << "\n--original-shader--\n" << (source ? *source : "")
+        << "\n--translated-shader--\n" << shader_src
+        << "\n--info-log--\n" << *info->log_info();
   }
 }
 
 bool ProgramManager::ProgramInfo::Link(ShaderManager* manager,
                                        ShaderTranslator* vertex_translator,
                                        ShaderTranslator* fragment_translator,
                                        FeatureInfo* feature_info) {
   ClearLinkStatus();
   if (!CanLink()) {
     set_log_info("missing shaders");
@@ skipping 652 matching lines @@
     info->ClearUniforms(&zero_);
   }
 }
 
 int32 ProgramManager::MakeFakeLocation(int32 index, int32 element) {
   return index + element * 0x10000;
 }
 
 }  // namespace gles2
 }  // namespace gpu