content/shell/shell_javascript_dialog_creator.h - Issue 10824077: Content shell/GTK: Add JavaScript dialog support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/shell_javascript_dialog_creator.h

Issue 10824077: Content shell/GTK: Add JavaScript dialog support. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix the style Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/shell_javascript_dialog_creator.h

diff --git a/content/shell/shell_javascript_dialog_creator.h b/content/shell/shell_javascript_dialog_creator.h

index 0dd67ced1849a0a6f55a6c6926f7473c812863e6..21e7ab11a40b6cbb72a7245fef81f6c80d8996cc 100644

--- a/content/shell/shell_javascript_dialog_creator.h

+++ b/content/shell/shell_javascript_dialog_creator.h

@@ -48,7 +48,7 @@ class ShellJavaScriptDialogCreator : public JavaScriptDialogCreator {

}

private:

-#if defined(OS_MACOSX) || defined(OS_WIN)

+#if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)

jochen (gone - plz use gerrit) 2012/07/30 08:15:49 please change OS_LINUX to TOOLKIT_GTK everywhere

Shouqun Liu 2012/07/30 08:26:21 Sorry, forget this... On 2012/07/30 08:15:49, joch

// The dialog being shown. No queueing.

scoped_ptr<ShellJavaScriptDialog> dialog_;

#else