chrome/browser/download/download_util.cc - Issue 10824067: Some fixes to run unit_tests bundle on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_util.cc

Issue 10824067: Some fixes to run unit_tests bundle on android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_util.cc

diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc

index f4fe085205cf915a76b4d13012c22ddb586dbe70..9ebddfb05fc40d0c634bf34de010737d421805d9 100644

--- a/chrome/browser/download/download_util.cc

+++ b/chrome/browser/download/download_util.cc

@@ -168,7 +168,6 @@ bool DownloadPathIsDangerous(const FilePath& download_path) {

FilePath desktop_dir;

if (!PathService::Get(chrome::DIR_USER_DESKTOP, &desktop_dir)) {

- NOTREACHED();

asanka 2012/07/27 19:19:46 If this check doesn't apply to OS_ANDROID, I'd rat

nilesh 2012/07/27 20:09:25 Done.

return false;

}

return (download_path == desktop_dir);

« no previous file with comments | « build/android/pylib/test_package.py ('k') | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »