Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: remoting/protocol/libjingle_transport_factory.cc

Issue 10824049: Disable TCP ports in the default LibjingleTransportFactory() constructor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/protocol/libjingle_transport_factory.h" 5 #include "remoting/protocol/libjingle_transport_factory.h"
6 6
7 #include "base/single_thread_task_runner.h" 7 #include "base/single_thread_task_runner.h"
8 #include "base/thread_task_runner_handle.h" 8 #include "base/thread_task_runner_handle.h"
9 #include "jingle/glue/channel_socket_adapter.h" 9 #include "jingle/glue/channel_socket_adapter.h"
10 #include "jingle/glue/pseudotcp_adapter.h" 10 #include "jingle/glue/pseudotcp_adapter.h"
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 incoming_only_(incoming_only) { 313 incoming_only_(incoming_only) {
314 } 314 }
315 315
316 LibjingleTransportFactory::LibjingleTransportFactory() 316 LibjingleTransportFactory::LibjingleTransportFactory()
317 : network_manager_(new talk_base::BasicNetworkManager()), 317 : network_manager_(new talk_base::BasicNetworkManager()),
318 socket_factory_(new talk_base::BasicPacketSocketFactory()), 318 socket_factory_(new talk_base::BasicPacketSocketFactory()),
319 http_port_allocator_(NULL), 319 http_port_allocator_(NULL),
320 port_allocator_(new cricket::BasicPortAllocator( 320 port_allocator_(new cricket::BasicPortAllocator(
321 network_manager_.get(), socket_factory_.get())), 321 network_manager_.get(), socket_factory_.get())),
322 incoming_only_(false) { 322 incoming_only_(false) {
323 int flags = cricket::PORTALLOCATOR_DISABLE_TCP |
324 cricket::PORTALLOCATOR_ENABLE_SHARED_UFRAG |
325 cricket::PORTALLOCATOR_DISABLE_STUN |
326 cricket::PORTALLOCATOR_DISABLE_RELAY;
327 port_allocator_->set_flags(flags);
simonmorris 2012/07/26 19:35:57 Maybe remove the flags variable?
Sergey Ulanov 2012/07/26 19:59:11 Done.
323 } 328 }
324 329
325 LibjingleTransportFactory::~LibjingleTransportFactory() { 330 LibjingleTransportFactory::~LibjingleTransportFactory() {
326 // This method may be called in response to a libjingle signal, so 331 // This method may be called in response to a libjingle signal, so
327 // libjingle objects must be deleted asynchronously. 332 // libjingle objects must be deleted asynchronously.
328 scoped_refptr<base::SingleThreadTaskRunner> task_runner = 333 scoped_refptr<base::SingleThreadTaskRunner> task_runner =
329 base::ThreadTaskRunnerHandle::Get(); 334 base::ThreadTaskRunnerHandle::Get();
330 task_runner->DeleteSoon(FROM_HERE, port_allocator_.release()); 335 task_runner->DeleteSoon(FROM_HERE, port_allocator_.release());
331 task_runner->DeleteSoon(FROM_HERE, socket_factory_.release()); 336 task_runner->DeleteSoon(FROM_HERE, socket_factory_.release());
332 task_runner->DeleteSoon(FROM_HERE, network_manager_.release()); 337 task_runner->DeleteSoon(FROM_HERE, network_manager_.release());
(...skipping 25 matching lines...) Expand all
358 } 363 }
359 364
360 scoped_ptr<DatagramTransport> 365 scoped_ptr<DatagramTransport>
361 LibjingleTransportFactory::CreateDatagramTransport() { 366 LibjingleTransportFactory::CreateDatagramTransport() {
362 NOTIMPLEMENTED(); 367 NOTIMPLEMENTED();
363 return scoped_ptr<DatagramTransport>(NULL); 368 return scoped_ptr<DatagramTransport>(NULL);
364 } 369 }
365 370
366 } // namespace protocol 371 } // namespace protocol
367 } // namespace remoting 372 } // namespace remoting
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698