Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 10824035: Send correct DPI to client. (Closed)

Created:
8 years, 4 months ago by Jamie
Modified:
8 years, 4 months ago
Reviewers:
Lambros, dcaiafa
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Send correct DPI to client. BUG=135089 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148618

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M remoting/host/video_frame_capturer_mac.mm View 4 chunks +8 lines, -0 lines 3 comments Download

Messages

Total messages: 5 (0 generated)
Jamie
Lambros, ptal, Dan, I've included you in case you have any expertise in this area. ...
8 years, 4 months ago (2012-07-26 00:57:16 UTC) #1
Lambros
lgtm with nit http://codereview.chromium.org/10824035/diff/1/remoting/host/video_frame_capturer_mac.mm File remoting/host/video_frame_capturer_mac.mm (right): http://codereview.chromium.org/10824035/diff/1/remoting/host/video_frame_capturer_mac.mm#newcode134 remoting/host/video_frame_capturer_mac.mm:134: int height = CGDisplayPixelsHigh(mainDevice); On 2012/07/26 ...
8 years, 4 months ago (2012-07-26 01:21:59 UTC) #2
dcaiafa
lgtm
8 years, 4 months ago (2012-07-26 16:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/10824035/1
8 years, 4 months ago (2012-07-26 18:13:01 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 20:32:52 UTC) #5
Change committed as 148618

Powered by Google App Engine
This is Rietveld 408576698