Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: chrome/common/extensions/docs/server2/static/js/samples.js

Issue 10824003: addEventListener stuff. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/templates/public/samples.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/server2/static/js/samples.js
diff --git a/chrome/common/extensions/docs/server2/static/js/samples.js b/chrome/common/extensions/docs/server2/static/js/samples.js
index 7a9efca053a8cc9c852f013d99ef71688f8f7c75..2b82a25947047dfa658cf33d524dd7f056c7e72b 100644
--- a/chrome/common/extensions/docs/server2/static/js/samples.js
+++ b/chrome/common/extensions/docs/server2/static/js/samples.js
@@ -4,29 +4,27 @@
(function() {
var search_box = document.getElementById('search_input');
- var apis = document.getElementsByClassName('sample');
- for (var i = 0; i < apis.length; ++i)
- apis[i].tags = apis[i].getAttribute('tags').toUpperCase();
+ var samples = document.getElementsByClassName('sample');
function filterSamples() {
- var search_text = search_box.value.toUpperCase();
- for (var i = 0; i < apis.length; ++i) {
- if (apis[i].tags.indexOf(search_text) < 0)
- apis[i].style.display = 'none';
+ var search_text = search_box.value.toLowerCase();
+ for (var i = 0; i < samples.length; ++i) {
+ var sample = samples[i];
+ if (sample.getAttribute('tags').indexOf(search_text) < 0)
+ sample.style.display = 'none';
else
- apis[i].style.display = '';
+ sample.style.display = '';
}
}
- function setFilter() {
- search_box.value = 'chrome.' + this.innerHTML;
- filterSamples();
- }
-
- var api_filter_items = document.getElementsByClassName('api_filter_item');
- for (var i = 0; i < api_filter_items.length; ++i)
- api_filter_items[i].addEventListener('click', setFilter, true);
+ search_box.addEventListener('search', filterSamples);
+ search_box.addEventListener('keyup', filterSamples);
- search_box.onsearch = filterSamples;
- search_box.onkeyup = filterSamples;
+ var api_filter_items = document.getElementById('api_filter_items');
+ api_filter_items.addEventListener('click', function(event) {
+ if (event.target instanceof HTMLAnchorElement) {
+ search_box.value = 'chrome.' + event.target.innerText;
+ filterSamples();
+ }
+ });
})();
« no previous file with comments | « no previous file | chrome/common/extensions/docs/server2/templates/public/samples.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698