remoting/codec/audio_encoder_verbatim.cc - Issue 10823420: Added more error checking for audio packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/codec/audio_encoder_verbatim.cc

Issue 10823420: Added more error checking for audio packets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/codec/audio_encoder_verbatim.cc

diff --git a/remoting/codec/audio_encoder_verbatim.cc b/remoting/codec/audio_encoder_verbatim.cc

index 52e578a117a39266fd27024d276e15a1218865dd..696035e9f0d60b72632e5e1bec90008195a16c65 100644

--- a/remoting/codec/audio_encoder_verbatim.cc

+++ b/remoting/codec/audio_encoder_verbatim.cc

@@ -17,6 +17,9 @@ scoped_ptr<AudioPacket> AudioEncoderVerbatim::Encode(

scoped_ptr<AudioPacket> packet) {

DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());

DCHECK_EQ(1, packet->data_size());

+ DCHECK_NE(AudioPacket::SAMPLING_RATE_INVALID, packet->sampling_rate());

+ DCHECK_NE(AudioPacket::BYTES_PER_SAMPLE_INVALID, packet->bytes_per_sample());

+ DCHECK_NE(AudioPacket::CHANNELS_INVALID, packet->channels());

return packet.Pass();

}