Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: remoting/client/plugin/pepper_audio_player.cc

Issue 10823420: Added more error checking for audio packets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_audio_player.cc
diff --git a/remoting/client/plugin/pepper_audio_player.cc b/remoting/client/plugin/pepper_audio_player.cc
index dae8c1e9ba7099b1fb2e175d65be80ce8d5df44b..d9c53a5729ee7e70fc311404e3b2e28c8fad7f49 100644
--- a/remoting/client/plugin/pepper_audio_player.cc
+++ b/remoting/client/plugin/pepper_audio_player.cc
@@ -75,12 +75,12 @@ void PepperAudioPlayer::ProcessAudioPacket(scoped_ptr<AudioPacket> packet) {
// TODO(kxing): Limit the size of the queue so that latency doesn't grow
// too large.
- // Drop null packets.
- if (!packet.get())
- return;
-
CHECK_EQ(1, packet->data_size());
DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());
+ DCHECK_NE(AudioPacket::SAMPLING_RATE_INVALID, packet->sampling_rate());
+ DCHECK_EQ(kSampleSizeBytes, packet->bytes_per_sample());
+ DCHECK_EQ(static_cast<int>(kChannels), packet->channels());
+
if (packet->data(0).size() % (kChannels * kSampleSizeBytes) != 0) {
LOG(WARNING) << "Received corrupted packet.";
return;

Powered by Google App Engine
This is Rietveld 408576698