Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/codec/audio_decoder_verbatim.cc

Issue 10823420: Added more error checking for audio packets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/client/audio_decode_scheduler.cc ('K') | « remoting/client/plugin/pepper_audio_player.cc ('k') | remoting/codec/audio_encoder_verbatim.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/audio_decoder_verbatim.cc
diff --git a/remoting/codec/audio_decoder_verbatim.cc b/remoting/codec/audio_decoder_verbatim.cc
index 903cb3f298b824a34928ac795c8566521321f9fa..ca2f97c30f7825e40e3838f3fa61344898c1518d 100644
--- a/remoting/codec/audio_decoder_verbatim.cc
+++ b/remoting/codec/audio_decoder_verbatim.cc
@@ -21,7 +21,9 @@ scoped_ptr<AudioPacket> AudioDecoderVerbatim::Decode(
if ((packet->encoding() != AudioPacket::ENCODING_RAW) ||
(packet->data_size() != 1) ||
(packet->sampling_rate() == AudioPacket::SAMPLING_RATE_INVALID) ||
- (packet->bytes_per_sample() == AudioPacket::BYTES_PER_SAMPLE_INVALID)) {
+ (packet->bytes_per_sample() != AudioPacket::BYTES_PER_SAMPLE_2) ||
+ (packet->channels() != AudioPacket::CHANNELS_STEREO)) {
+ LOG(WARNING) << "Verbatim decoder received a corrupt packet.";
Wez 2012/08/20 23:23:51 nit: a correct -> an invalid
kxing 2012/08/21 14:25:53 Done.
return scoped_ptr<AudioPacket>();
}
return packet.Pass();
« remoting/client/audio_decode_scheduler.cc ('K') | « remoting/client/plugin/pepper_audio_player.cc ('k') | remoting/codec/audio_encoder_verbatim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698