Added more error checking for audio packets.

remoting/codec/audio_decoder_verbatim.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/codec/audio_decoder_verbatim.h"
 
 #include "base/logging.h"
 #include "remoting/proto/audio.pb.h"
 
 namespace remoting {
 
 AudioDecoderVerbatim::AudioDecoderVerbatim() {
 }
 
 AudioDecoderVerbatim::~AudioDecoderVerbatim() {
 }
 
 scoped_ptr<AudioPacket> AudioDecoderVerbatim::Decode(
     scoped_ptr<AudioPacket> packet) {
   // Return a null scoped_ptr if we get a corrupted packet.
   if ((packet->encoding() != AudioPacket::ENCODING_RAW) ||
       (packet->data_size() != 1) ||
       (packet->sampling_rate() == AudioPacket::SAMPLING_RATE_INVALID) ||
-      (packet->bytes_per_sample() == AudioPacket::BYTES_PER_SAMPLE_INVALID)) {
+      (packet->bytes_per_sample() == AudioPacket::BYTES_PER_SAMPLE_INVALID) ||

[Sergey Ulanov, 2012/08/20 22:26:20]

here you want to check that bytes_per_sample() == 2 as that's the only format
currently supported by the player.

[kxing, 2012/08/20 22:48:22]

Done.

+      (packet->channels() == AudioPacket::CHANNELS_INVALID)) {

[Sergey Ulanov, 2012/08/20 22:26:20]

check that we have two channels, not only that the number of channels is valid.
If the host sends us Mono stream the current player implementation will try to
play it as stereo.

[kxing, 2012/08/20 22:48:22]

Done.

     return scoped_ptr<AudioPacket>();
   }
   return packet.Pass();
 }
 
 }  // namespace remoting