Added more error checking for audio packets.

remoting/client/plugin/pepper_audio_player.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/pepper_audio_player.h"
 
 #include <algorithm>
 
 #include "base/stl_util.h"
 
@@ skipping 58 matching lines @@
   if (!success)
     LOG(ERROR) << "Failed to start Pepper audio player";
   return success;
 }
 
 void PepperAudioPlayer::ProcessAudioPacket(scoped_ptr<AudioPacket> packet) {
   // TODO(kxing): Limit the size of the queue so that latency doesn't grow
   // too large.
 
   // Drop null packets.
   if (!packet.get())

[Sergey Ulanov, 2012/08/20 22:26:20]

I think I already mentioned in one of the previous reviews - it's better to
check for this in AudioDecodeScheduler and call ProcessAudioPacket() only for
not-null packets.

[kxing, 2012/08/20 22:48:22]

Done.

     return;
 
   CHECK_EQ(1, packet->data_size());
   DCHECK_EQ(AudioPacket::ENCODING_RAW, packet->encoding());
+  DCHECK_NE(AudioPacket::SAMPLING_RATE_INVALID, packet->sampling_rate());
+  DCHECK_NE(AudioPacket::BYTES_PER_SAMPLE_INVALID, packet->bytes_per_sample());

[Sergey Ulanov, 2012/08/20 22:26:20]

check that bytes_per_sample() == kSampleSizeBytes?

[kxing, 2012/08/20 22:48:22]

Done.

+  DCHECK_NE(AudioPacket::CHANNELS_INVALID, packet->channels());

[Sergey Ulanov, 2012/08/20 22:26:20]

I think you want to check that channels()==kChannels. The player currently
supports only two channels.

[kxing, 2012/08/20 22:48:22]

Done.

   if (packet->data(0).size() % (kChannels * kSampleSizeBytes) != 0) {

[Sergey Ulanov, 2012/08/20 22:26:20]

add empty line above this one.

[kxing, 2012/08/20 22:48:22]

Done.

     LOG(WARNING) << "Received corrupted packet.";
     return;
   }
   base::AutoLock auto_lock(lock_);
 
   // No-op if the Pepper player won't start.
   if (start_failed_) {
     return;
   }
 
@@ skipping 54 matching lines @@
         bytes_needed - bytes_extracted);
     memcpy(next_sample, packet_data.data() + bytes_consumed_, bytes_to_copy);
 
     next_sample += bytes_to_copy;
     bytes_consumed_ += bytes_to_copy;
     bytes_extracted += bytes_to_copy;
   }
 }
 
 }  // namespace remoting