chrome/browser/download/save_page_browsertest.cc - Issue 10823406: Remove DownloadFileManager in favor of direct ownership of DownloadFiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/save_page_browsertest.cc

Issue 10823406: Remove DownloadFileManager in favor of direct ownership of DownloadFiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: 'Integrate' with SavePacakge. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/save_page_browsertest.cc

diff --git a/chrome/browser/download/save_page_browsertest.cc b/chrome/browser/download/save_page_browsertest.cc

index c2cba5a8e3c1c804b36161199ab1298b8ba86f4b..aeed5612946940cfb40d40a9609940bdf9a2b617 100644

--- a/chrome/browser/download/save_page_browsertest.cc

+++ b/chrome/browser/download/save_page_browsertest.cc

@@ -314,7 +314,6 @@ IN_PROC_BROWSER_TEST_F(SavePageBrowserTest, SaveHTMLOnlyCancel) {

EXPECT_EQ(url, WaitForSavePackageToFinish());

EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());

- CheckDownloadHistory(url, full_file_name, 1); // a.htm is 1 file.

EXPECT_TRUE(file_util::PathExists(full_file_name));

EXPECT_FALSE(file_util::PathExists(dir));

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | content/browser/browser_context.cc » ('j') | content/browser/download/save_package.cc » ('J')