Implement import scope

runtime/vm/parser.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_PARSER_H_
 #define VM_PARSER_H_
 
 #include "include/dart_api.h"
 
 #include "vm/ast.h"
@@ skipping 464 matching lines @@
   void CheckInstanceFieldAccess(intptr_t field_pos, const String& field_name);
   RawClass* TypeParametersScopeClass() const;
   const Type* ReceiverType(intptr_t type_pos) const;
   bool IsInstantiatorRequired() const;
   bool IsDefinedInLexicalScope(const String& ident);
   bool ResolveIdentInLocalScope(intptr_t ident_pos,
                                 const String &ident,
                                 AstNode** node);
   static const bool kResolveLocally = true;
   static const bool kResolveIncludingImports = false;
-  AstNode* ResolveIdentInLibraryScope(const Library& lib,
-                                      const QualIdent& qual_ident,
-                                      bool resolve_locally);
-  AstNode* ResolveIdentInLibraryPrefixScope(const LibraryPrefix& lib_prefix,
-                                            const QualIdent& qual_ident);
+  AstNode* ResolveIdentInPrefixScope(intptr_t ident_pos,
+                                     const LibraryPrefix& prefix,
+                                     const String& ident);
+  RawClass* ResolveClassInPrefixScope(intptr_t ident_pos,
+                                      const LibraryPrefix& prefix,
+                                      const String& name);
+  RawClass* ResolveClassInCurrentLibraryScope(intptr_t ident_pos,
+                                              const String& name);
+  RawObject* ResolveNameInCurrentLibraryScope(intptr_t ident_pos,
+                                              const String& ident);
+  RawObject* ResolveNameInPrefixScope(intptr_t ident_pos,
+                                      const LibraryPrefix& prefix,
+                                      const String& name);
+  AstNode* ResolveIdentInCurrentLibraryScope(intptr_t ident_pos,
+                                             const String& ident);

[regis, 2012/08/17 20:23:07]

Reorder these 6 methods and group them in pairs.
Explaining in a comment the difference between a Name and an Ident would be
helpful.

[hausner, 2012/08/17 21:05:52]

Done.

   AstNode* ResolveIdent(intptr_t ident_pos,
                         const String& ident,
                         bool allow_closure_names);
   RawString* ResolveImportVar(intptr_t ident_pos, const String& ident);
   AstNode* OptimizeBinaryOpNode(intptr_t op_pos,
                                 Token::Kind binary_op,
                                 AstNode* lhs,
                                 AstNode* rhs);
   AstNode* ExpandAssignableOp(intptr_t op_pos,
                               Token::Kind assignment_op,
@@ skipping 71 matching lines @@
 
   // Allocate temporary only once per function.
   LocalVariable* expression_temp_;
 
   DISALLOW_COPY_AND_ASSIGN(Parser);
 };
 
 }  // namespace dart
 
 #endif  // VM_PARSER_H_