Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10823358: image: Specify the resize-method when resizing ImageSkia. (Closed)

Created:
8 years, 4 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, rsesek+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

image: Specify the resize-method when resizing ImageSkia. This makes the ImageSkia resizing code mirror the SkBitmap resizing code more closely. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151972

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : deep-copy #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -26 lines) Patch
M ash/launcher/launcher_button.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 7 chunks +35 lines, -16 lines 1 comment Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_item_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/image/image_skia_operations.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/image/image_skia_operations.cc View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sadrul
8 years, 4 months ago (2012-08-16 03:06:31 UTC) #1
sky
http://codereview.chromium.org/10823358/diff/3001/chrome/browser/chromeos/login/wallpaper_manager.cc File chrome/browser/chromeos/login/wallpaper_manager.cc (right): http://codereview.chromium.org/10823358/diff/3001/chrome/browser/chromeos/login/wallpaper_manager.cc#newcode522 chrome/browser/chromeos/login/wallpaper_manager.cc:522: gfx::ImageSkia thumbnail = gfx::ImageSkiaOperations::CreateResizedImage( This code runs off the ...
8 years, 4 months ago (2012-08-16 16:25:59 UTC) #2
sadrul
http://codereview.chromium.org/10823358/diff/3001/chrome/browser/chromeos/login/wallpaper_manager.cc File chrome/browser/chromeos/login/wallpaper_manager.cc (right): http://codereview.chromium.org/10823358/diff/3001/chrome/browser/chromeos/login/wallpaper_manager.cc#newcode522 chrome/browser/chromeos/login/wallpaper_manager.cc:522: gfx::ImageSkia thumbnail = gfx::ImageSkiaOperations::CreateResizedImage( On 2012/08/16 16:25:59, sky wrote: ...
8 years, 4 months ago (2012-08-16 17:15:12 UTC) #3
sky
That may be. Could you fix now?
8 years, 4 months ago (2012-08-16 19:26:30 UTC) #4
sadrul
I have made some changes (make a deep-copy of the ImageSkia before it is sent ...
8 years, 4 months ago (2012-08-16 20:32:56 UTC) #5
sky
8 years, 4 months ago (2012-08-16 20:56:36 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698