Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: content/browser/android/content_view_client.cc

Issue 10823340: [Android] Upstream Modal Dialogs functionality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_client.cc
diff --git a/content/browser/android/content_view_client.cc b/content/browser/android/content_view_client.cc
index d4e08fbc7260e000593302051a639d2086ec194b..e3bd50e2c0d83b33b0b15b6b521410b190808b97 100644
--- a/content/browser/android/content_view_client.cc
+++ b/content/browser/android/content_view_client.cc
@@ -132,11 +132,12 @@ void ContentViewClient::SetJavaScriptDialogCreator(
javascript_dialog_creator_ = javascript_dialog_creator;
}
-bool ContentViewClient::OnJSModalDialog(JavaScriptMessageType type,
+bool ContentViewClient::OnJsModalDialog(JavaScriptMessageType type,
bool is_before_unload_dialog,
const GURL& url,
const string16& message,
- const string16& default_value) {
+ const string16& default_value,
+ jobject js_result) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jstring> jurl(ConvertUTF8ToJavaString(env, url.spec()));
ScopedJavaLocalRef<jstring> jmessage(ConvertUTF16ToJavaString(env, message));
@@ -147,7 +148,8 @@ bool ContentViewClient::OnJSModalDialog(JavaScriptMessageType type,
return Java_ContentViewClient_onJsBeforeUnload(env,
weak_java_client_.get(env).obj(),
jurl.obj(),
- jmessage.obj());
+ jmessage.obj(),
+ js_result);
}
switch (type) {
@@ -155,13 +157,15 @@ bool ContentViewClient::OnJSModalDialog(JavaScriptMessageType type,
return Java_ContentViewClient_onJsAlert(env,
weak_java_client_.get(env).obj(),
jurl.obj(),
- jmessage.obj());
+ jmessage.obj(),
+ js_result);
case JAVASCRIPT_MESSAGE_TYPE_CONFIRM:
return Java_ContentViewClient_onJsConfirm(env,
weak_java_client_.get(env).obj(),
jurl.obj(),
- jmessage.obj());
+ jmessage.obj(),
+ js_result);
case JAVASCRIPT_MESSAGE_TYPE_PROMPT: {
ScopedJavaLocalRef<jstring> jdefault_value(
@@ -170,7 +174,8 @@ bool ContentViewClient::OnJSModalDialog(JavaScriptMessageType type,
weak_java_client_.get(env).obj(),
jurl.obj(),
jmessage.obj(),
- jdefault_value.obj());
+ jdefault_value.obj(),
+ js_result);
}
default:

Powered by Google App Engine
This is Rietveld 408576698