add unit tests for MediaGalleriesDialogGtk

chrome/browser/media_gallery/media_galleries_dialog_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_
 #define CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_
 
 #include <list>
 #include <map>
 
@@ skipping 51 matching lines @@
 
   // The constructor creates a dialog controller which owns itself.
   MediaGalleriesDialogController(TabContents* tab_contents,
                                  const extensions::Extension& extension,
                                  const base::Callback<void(void)>& on_finish);
 
   // Called by the view.
   string16 GetHeader();
   string16 GetSubtext();
   void OnAddFolderClicked();
-  void GalleryToggled(const MediaGalleryPrefInfo* pref_info, bool enabled);
-  void DialogFinished(bool accepted);
+  virtual void GalleryToggled(const MediaGalleryPrefInfo* pref_info,
+                              bool enabled);
+  virtual void DialogFinished(bool accepted);
 
   // SelectFileDialog::Listener implementation:
   virtual void FileSelected(const FilePath& path,
                             int index,
                             void* params) OVERRIDE;
   const KnownGalleryPermissions& permissions() const {
     return known_galleries_;
   }
 
   TabContents* tab_contents() const {
     return tab_contents_;
   }
 
+ protected:
+  // For use with tests.
+  MediaGalleriesDialogController();
+
+  virtual ~MediaGalleriesDialogController();
+
+  // This map excludes those galleries which have been blacklisted; it only
+  // counts active known galleries.
+  KnownGalleryPermissions known_galleries_;
+
  private:
   // This type is for media galleries that have been added via "add gallery"
   // button, but have not yet been committed to the prefs system and will be
   // forgotten if the user Cancels. Since they don't have IDs assigned yet, it's
   // just a list and not a map.
   typedef std::list<GalleryPermission> NewGalleryPermissions;
 
-  virtual ~MediaGalleriesDialogController();
-
   // Populates |known_galleries_|.
   void LookUpPermissions();
 
   // Saves state of |known_galleries_| and |new_galleries_| to model.
   void SavePermissions();
 
   // The tab contents from which the request originated.
   TabContents* tab_contents_;
 
   // This is just a reference, but it's assumed that it won't become invalid
-  // while the dialog is showing.
-  const extensions::Extension& extension_;
+  // while the dialog is showing. Will be NULL only during tests.
+  const extensions::Extension* extension_;
 
-  // This map excludes those galleries which have been blacklisted; it only
-  // counts active known galleries.
-  KnownGalleryPermissions known_galleries_;
   NewGalleryPermissions new_galleries_;
 
   // We run this callback when done.
   base::Callback<void(void)> on_finish_;
 
   // The model that tracks galleries and extensions' permissions.
   MediaGalleriesPreferences* preferences_;
 
   // The view that's showing.
   scoped_ptr<MediaGalleriesDialog> dialog_;
 
   scoped_refptr<ui::SelectFileDialog> select_folder_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogController);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_MEDIA_GALLERY_MEDIA_GALLERIES_DIALOG_CONTROLLER_H_