add unit tests for MediaGalleriesDialogGtk

chrome/browser/media_gallery/media_galleries_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media_gallery/media_galleries_dialog_controller.h"
 
 #include "base/path_service.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/media_gallery/media_galleries_preferences_factory.h"
 #include "chrome/browser/ui/chrome_select_file_policy.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using extensions::Extension;
 
 namespace chrome {
 
 MediaGalleriesDialogController::MediaGalleriesDialogController(
     TabContents* tab_contents,
     const Extension& extension,
     const base::Callback<void(void)>& on_finish)
       : tab_contents_(tab_contents),
-        extension_(extension),
+        extension_(&extension),
         on_finish_(on_finish),
         preferences_(MediaGalleriesPreferencesFactory::GetForProfile(
-          tab_contents_->profile())) {
+            tab_contents_->profile())) {
   LookUpPermissions();
 
   dialog_.reset(MediaGalleriesDialog::Create(this));
 }
 
+MediaGalleriesDialogController::MediaGalleriesDialogController()
+    : tab_contents_(NULL),
+      extension_(NULL),
+      preferences_(NULL) {}
+
 MediaGalleriesDialogController::~MediaGalleriesDialogController() {
   if (select_folder_dialog_.get())
     select_folder_dialog_->ListenerDestroyed();
 }
 
 string16 MediaGalleriesDialogController::GetHeader() {
+  std::string extension_name(extension_ ? extension_->name() : "");
   return l10n_util::GetStringFUTF16(IDS_MEDIA_GALLERIES_DIALOG_HEADER,
-                                    UTF8ToUTF16(extension_.name()));
+                                    UTF8ToUTF16(extension_name));
 }
 
 string16 MediaGalleriesDialogController::GetSubtext() {
-  if (extension_.HasAPIPermission(
+  if (extension_ && extension_->HasAPIPermission(
           extensions::APIPermission::kMediaGalleriesRead)) {
     return l10n_util::GetStringFUTF16(IDS_MEDIA_GALLERIES_DIALOG_READ_SUBTEXT,
-                                      UTF8ToUTF16(extension_.name()));
+                                      UTF8ToUTF16(extension_->name()));
   }
   // TODO(estade): handle write et al.
   return string16();
 }
 
 void MediaGalleriesDialogController::OnAddFolderClicked() {
   FilePath user_data_dir;
   PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
   // TODO(estade): if file dialogs are disabled we need to handle it somehow.
   select_folder_dialog_ =
@@ skipping 80 matching lines @@
            preferences_->known_galleries().begin();
        iter != preferences_->known_galleries().end();
        ++iter) {
     if (iter->second.type == MediaGalleryPrefInfo::kBlackListed)
       continue;
 
     known_galleries_[iter->first] = GalleryPermission(iter->second, false);
   }
 
   MediaGalleryPrefIdSet permitted =
-      preferences_->GalleriesForExtension(extension_);
+      preferences_->GalleriesForExtension(*extension_);
 
   for (MediaGalleryPrefIdSet::iterator iter = permitted.begin();
        iter != permitted.end(); ++iter) {
     known_galleries_[*iter].allowed = true;
   }
 }
 
 void MediaGalleriesDialogController::SavePermissions() {
   for (KnownGalleryPermissions::iterator iter = known_galleries_.begin();
        iter != known_galleries_.end(); ++iter) {
     preferences_->SetGalleryPermissionForExtension(
-        extension_, iter->first, iter->second.allowed);
+        *extension_, iter->first, iter->second.allowed);
   }
 
   for (NewGalleryPermissions::iterator iter = new_galleries_.begin();
        iter != new_galleries_.end(); ++iter) {
     // If the user added a gallery then unchecked it, forget about it.
     if (!iter->allowed)
       continue;
 
     const MediaGalleryPrefInfo& gallery = iter->pref_info;
     MediaGalleryPrefId id = preferences_->AddGallery(
         gallery.device_id, gallery.display_name, gallery.path, true);
     preferences_->SetGalleryPermissionForExtension(
-        extension_, id, true);
+        *extension_, id, true);
   }
 }
 
 // MediaGalleries dialog -------------------------------------------------------
 
 MediaGalleriesDialog::~MediaGalleriesDialog() {}
 
 }  // namespace chrome