bluetooth: Create stub manager, adapter and device.

chromeos/dbus/bluetooth_adapter_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/bluetooth_adapter_client.h"
 
 #include <map>
 #include <utility>
 
 #include "base/bind.h"
 #include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "chromeos/dbus/bluetooth_device_client.h"
 #include "chromeos/dbus/bluetooth_manager_client.h"
 #include "chromeos/dbus/bluetooth_property.h"
 #include "dbus/bus.h"
 #include "dbus/message.h"
 #include "dbus/object_path.h"
 #include "dbus/object_proxy.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
@@ skipping 700 matching lines @@
   // List of observers interested in event notifications from us.
   ObserverList<BluetoothAdapterClient::Observer> observers_;
 
   DISALLOW_COPY_AND_ASSIGN(BluetoothAdapterClientImpl);
 };
 
 // The BluetoothAdapterClient implementation used on Linux desktop, which does
 // nothing.
 class BluetoothAdapterClientStubImpl : public BluetoothAdapterClient {
  public:
+  struct Properties : public BluetoothAdapterClient::Properties {
+    explicit Properties(PropertyChangedCallback callback)

[satorux1, 2012/08/14 16:54:19]

you can  make it const PropertyChangedCallback&

[keybuk, 2012/08/14 17:40:32]

Done.

+        : BluetoothAdapterClient::Properties(NULL, callback) {
+    }
+
+    virtual ~Properties() {
+    }
+
+    virtual void Get(dbus::PropertyBase* property,
+                     dbus::PropertySet::GetCallback callback) OVERRIDE {
+      VLOG(1) << "Get " << property->name();

[bryeung, 2012/08/14 13:10:29]

Probably better as DVLOG?

[satorux1, 2012/08/14 16:54:19]

agreed

[keybuk, 2012/08/14 17:40:32]

we've argued about this before - these are used only in the chromeos=1 on Linux
case, which are often release builds which is why they're not DVLOG - so UI
designers can verify the buttons would do something when clicked

[satorux1, 2012/08/14 17:52:04]

IIRC, the reason why DVLOG(1) is preferred was that every VLOG line adds non
negligible bytes to the shipping binary (the number of bytes used in the string
literal + some code generated for the log macro).

I guess that the UI designers (maybe UI engineers?) can build a Debug binary
instead of a Release binary.

[keybuk, 2012/08/14 17:58:46]

UI designers don't build anything

+      callback.Run(false);
+    }
+
+    virtual void GetAll() OVERRIDE {
+      VLOG(1) << "GetAll";

[satorux1, 2012/08/14 16:54:19]

ditto. please fix other places too.

+    }
+
+    virtual void Set(dbus::PropertyBase *property,
+                     dbus::PropertySet::SetCallback callback) OVERRIDE {
+      VLOG(1) << "Set " << property->name();
+      if (property->name() == "Powered") {
+        property->ReplaceValueWithSetValue();
+        NotifyPropertyChanged(property->name());
+        callback.Run(true);
+      } else {
+        callback.Run(false);
+      }
+    }
+  };
+
+  BluetoothAdapterClientStubImpl() {
+    properties_.reset(new Properties(base::Bind(
+        &BluetoothAdapterClientStubImpl::OnPropertyChanged,
+        base::Unretained(this))));
+
+    properties_->address.ReplaceValue("hci0");
+    properties_->name.ReplaceValue("Fake Adapter");
+    properties_->pairable.ReplaceValue(true);
+
+    std::vector<dbus::ObjectPath> devices;
+    devices.push_back(dbus::ObjectPath("/fake/hci0/dev0"));
+    properties_->devices.ReplaceValue(devices);
+  }
+
   // BluetoothAdapterClient override.
   virtual void AddObserver(Observer* observer) OVERRIDE {
+    observers_.AddObserver(observer);
   }
 
   // BluetoothAdapterClient override.
   virtual void RemoveObserver(Observer* observer) OVERRIDE {
+    observers_.RemoveObserver(observer);
   }
 
   // BluetoothAdapterClient override.
   virtual Properties* GetProperties(const dbus::ObjectPath& object_path)
       OVERRIDE {
     VLOG(1) << "GetProperties: " << object_path.value();
-    return NULL;
+    if (object_path.value() == "/fake/hci0")
+      return properties_.get();
+    else
+      return NULL;
   }
 
   // BluetoothAdapterClient override.
   virtual void RequestSession(const dbus::ObjectPath& object_path,
                               const AdapterCallback& callback) OVERRIDE {
     VLOG(1) << "RequestSession: " << object_path.value();
     callback.Run(object_path, false);
   }
 
   // BluetoothAdapterClient override.
@@ skipping 75 matching lines @@
   }
 
   // BluetoothAdapterClient override.
   virtual void UnregisterAgent(const dbus::ObjectPath& object_path,
                                const dbus::ObjectPath& agent_path,
                                const AdapterCallback& callback) OVERRIDE {
     VLOG(1) << "UnregisterAgent: " << object_path.value()
             << " " << agent_path.value();
     callback.Run(object_path, false);
   }
+
+ private:
+  // List of observers interested in event notifications from us.

[bryeung, 2012/08/14 13:10:29]

looks like this belongs with the variable below

[keybuk, 2012/08/14 17:40:32]

Done.

+  void OnPropertyChanged(const std::string& property_name) {
+    FOR_EACH_OBSERVER(BluetoothAdapterClient::Observer, observers_,
+                      AdapterPropertyChanged(dbus::ObjectPath("/fake/hci0"),

[satorux1, 2012/08/14 16:54:19]

I saw this before. you might want to define constants for the fake stuff.

[keybuk, 2012/08/14 17:40:32]

I couldn't find a useful place to put them, since they're spread across the
different files - thoughts?

[satorux1, 2012/08/14 17:52:04]

You could add a new file like bluetooth_stub_constants.h, but I guess it's
overkill.

+                                             property_name));
+  }
+
+  ObserverList<Observer> observers_;
+
+  // Static properties we return.
+  scoped_ptr<Properties> properties_;
 };
 
 BluetoothAdapterClient::BluetoothAdapterClient() {
 }
 
 BluetoothAdapterClient::~BluetoothAdapterClient() {
 }
 
 BluetoothAdapterClient* BluetoothAdapterClient::Create(
     DBusClientImplementationType type,
     dbus::Bus* bus,
     BluetoothManagerClient* manager_client) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new BluetoothAdapterClientImpl(bus, manager_client);
   DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
   return new BluetoothAdapterClientStubImpl();
 }
 
 }  // namespace chromeos