Adding "send to mobile" and "add bookmark" to the action box menu and wiring to their respective ac…

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
@@ skipping 102 matching lines @@
   if (!profile_->IsOffTheRecord() && profile_->IsSyncAccessible() &&
       ChromeToMobileService::IsChromeToMobileEnabled()) {
     command_updater_->AddCommandObserver(IDC_CHROME_TO_MOBILE_PAGE, this);
     chrome_to_mobile_decoration_.reset(
         new ChromeToMobileDecoration(profile, command_updater));
     ChromeToMobileServiceFactory::GetForProfile(profile)->
         RequestMobileListUpdate();
   }
 
   if (extensions::switch_utils::IsActionBoxEnabled()) {
-    plus_decoration_.reset(new PlusDecoration(this, command_updater, browser_));
+    plus_decoration_.reset(new PlusDecoration(this, command_updater, browser_,
+                                              profile_));

[Scott Hess - ex-Googler, 2012/08/13 18:54:43]

Make this call consistent WRT use of parameter values versus member variables. 
I'm not sure if we have a style guideline, but I just noticed that it was
inconsistent.

Also ... would browser_->profile() work for PlusDecoration instead?

[beaudoin, 2012/08/17 20:04:21]

Good question, I did not know of browser_->profile(). Any idea why
LocationBarViewMac takes both Browser and Profile in this case?

[Scott Hess - ex-Googler, 2012/08/17 20:39:15]

LocationBarView* dates from deepest darkest times.  IOW, I don't know.  It just
looks like lots of stuff would break if browser_->profile() doesn't work.

   }
 
   for (size_t i = 0; i < CONTENT_SETTINGS_NUM_TYPES; ++i) {
     DCHECK_EQ(i, content_setting_decorations_.size());
     ContentSettingsType type = static_cast<ContentSettingsType>(i);
     content_setting_decorations_.push_back(
         new ContentSettingDecoration(type, this, profile_));
   }
 
   registrar_.Add(this,
@@ skipping 592 matching lines @@
 void LocationBarViewMac::UpdateChromeToMobileEnabled() {
   if (!chrome_to_mobile_decoration_.get())
     return;
 
   DCHECK(ChromeToMobileService::IsChromeToMobileEnabled());
   bool enabled = [field_ isEditable] && !toolbar_model_->input_in_progress() &&
       ChromeToMobileServiceFactory::GetForProfile(profile_)->HasMobiles();
   chrome_to_mobile_decoration_->SetVisible(enabled);
   command_updater_->UpdateCommandEnabled(IDC_CHROME_TO_MOBILE_PAGE, enabled);
 }