Integrate external mount points to IsolatedContext

webkit/fileapi/file_system_url.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_url.h"
 
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/isolated_context.h"
 
 namespace fileapi {
 
 FileSystemURL::FileSystemURL()
     : type_(kFileSystemTypeUnknown), is_valid_(false) {}
 
 FileSystemURL::FileSystemURL(const GURL& url)
     : type_(kFileSystemTypeUnknown) {
-  is_valid_ = CrackFileSystemURL(url, &origin_, &type_, &path_);
+  is_valid_ = CrackFileSystemURL(url, &origin_, &type_, &virtual_path_);
   MayCrackIsolatedPath();
 }
 
 FileSystemURL::FileSystemURL(
     const GURL& origin,
     FileSystemType type,
     const FilePath& path)
     : origin_(origin),
       type_(type),
-      path_(path),
+      virtual_path_(path),
       is_valid_(true) {
   MayCrackIsolatedPath();
 }
 
 FileSystemURL::~FileSystemURL() {}
 
 std::string FileSystemURL::spec() const {
   if (!is_valid_)
     return std::string();
   return GetFileSystemRootURI(origin_, type_).spec() + "/" +
-      path_.AsUTF8Unsafe();
+      virtual_path_.AsUTF8Unsafe();
 }
 
 FileSystemURL FileSystemURL::WithPath(const FilePath& path) const {
-  return FileSystemURL(origin(), type(), path);
+  FileSystemURL url(*this);
+  url.path_ = path;

[tzik, 2012/08/20 03:58:50]

Could you invalidate virtual_path here?

[kinuko, 2012/08/20 08:54:35]

Done.

+  return url;
 }
 
 bool FileSystemURL::operator==(const FileSystemURL& that) const {
   return origin_ == that.origin_ &&
       type_ == that.type_ &&
       path_ == that.path_ &&
+      virtual_path_ == that.virtual_path_ &&
       filesystem_id_ == that.filesystem_id_ &&
       is_valid_ == that.is_valid_;
 }
 
 void FileSystemURL::MayCrackIsolatedPath() {
-  if (is_valid_ && type_ == kFileSystemTypeIsolated) {
+  path_ = virtual_path_;
+  if (is_valid_ && IsolatedContext::IsIsolatedType(type_)) {
     // If the type is isolated, crack the path further to get the 'real'
     // filesystem type and path.
     is_valid_ = IsolatedContext::GetInstance()->CrackIsolatedPath(
-        path_, &filesystem_id_, &type_, &path_);
+        virtual_path_, &filesystem_id_, &type_, &path_);
   }
 }
 
 }  // namespace fileapi