Fix ONC password filtering in about:policy.

chrome/browser/policy/configuration_policy_handler_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler_chromeos.h"
 
+#include <algorithm>
 #include <string>
+#include <vector>

[Joao da Silva, 2012/08/09 09:24:52]

Nit: <algorithm> and <vector> not used anymore

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

 
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
+#include "base/values.h"
+#include "chrome/browser/chromeos/cros/onc_constants.h"
 #include "chrome/browser/chromeos/cros/onc_network_parser.h"
 #include "chrome/browser/policy/policy_error_map.h"
 #include "chrome/browser/policy/policy_map.h"
 #include "chrome/browser/prefs/pref_value_map.h"
 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h"
 #include "chrome/common/pref_names.h"
 #include "grit/generated_resources.h"
 #include "policy/policy_constants.h"
 
+namespace onc = chromeos::onc;
+
 namespace policy {
 
 NetworkConfigurationPolicyHandler::NetworkConfigurationPolicyHandler(
     const char* policy_name,
     chromeos::NetworkUIData::ONCSource onc_source)
-    : TypeCheckingPolicyHandler(policy_name, Value::TYPE_STRING),
+    : TypeCheckingPolicyHandler(policy_name, base::Value::TYPE_STRING),
       onc_source_(onc_source) {}
 
 NetworkConfigurationPolicyHandler::~NetworkConfigurationPolicyHandler() {}
 
 bool NetworkConfigurationPolicyHandler::CheckPolicySettings(
     const PolicyMap& policies,
     PolicyErrorMap* errors) {
-  const Value* value;
+  const base::Value* value;
   if (!CheckAndGetValue(policies, errors, &value))
     return false;
 
   if (value) {
     std::string onc_blob;
     value->GetAsString(&onc_blob);
     // Policy-based ONC blobs cannot have a passphrase.
     chromeos::OncNetworkParser parser(onc_blob, "", onc_source_);
     if (!parser.parse_error().empty()) {
       errors->AddError(policy_name(),
@@ skipping 11 matching lines @@
     PrefValueMap* prefs) {
   // Network policy is read directly from the provider and injected into
   // NetworkLibrary, so no need to convert the policy settings into prefs.
 }
 
 void NetworkConfigurationPolicyHandler::PrepareForDisplaying(
     PolicyMap* policies) const {
   const PolicyMap::Entry* entry = policies->Get(policy_name());
   if (!entry)
     return;
-  Value* sanitized_config = SanitizeNetworkConfig(entry->value);
+  base::Value* sanitized_config = SanitizeNetworkConfig(entry->value);
   if (!sanitized_config)
-    sanitized_config = Value::CreateNullValue();
+    sanitized_config = base::Value::CreateNullValue();
 
   policies->Set(policy_name(), entry->level, entry->scope, sanitized_config);
 }
 
 // static
-Value* NetworkConfigurationPolicyHandler::SanitizeNetworkConfig(
-    const Value* config) {
+base::Value* NetworkConfigurationPolicyHandler::SanitizeNetworkConfig(
+    const base::Value* config) {
   std::string json_string;
   if (!config->GetAsString(&json_string))
     return NULL;
 
   scoped_ptr<Value> json_value(
       base::JSONReader::Read(json_string, base::JSON_ALLOW_TRAILING_COMMAS));
   if (!json_value.get() || !json_value->IsType(base::Value::TYPE_DICTIONARY))
     return NULL;
 
   DictionaryValue* config_dict =

[Joao da Silva, 2012/08/09 09:24:52]

Nit: base::

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

       static_cast<DictionaryValue*>(json_value.get());

[Joao da Silva, 2012/08/09 09:24:52]

Nit: base::

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

 
   // Strip any sensitive information from the JSON dictionary.
   base::ListValue* config_list = NULL;
   if (config_dict->GetList("NetworkConfigurations", &config_list)) {
     for (base::ListValue::const_iterator network_entry = config_list->begin();
          network_entry != config_list->end();
          ++network_entry) {
       if ((*network_entry) &&
           (*network_entry)->IsType(base::Value::TYPE_DICTIONARY)) {
-        StripSensitiveValues(static_cast<DictionaryValue*>(*network_entry));
+        MaskSensitiveValues(static_cast<DictionaryValue*>(*network_entry));

[Joao da Silva, 2012/08/09 09:24:52]

Nit: base::

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

       }
     }
   }
 
   // Convert back to a string, pretty printing the contents.
   base::JSONWriter::WriteWithOptions(config_dict,
                                      base::JSONWriter::OPTIONS_DO_NOT_ESCAPE |
                                          base::JSONWriter::OPTIONS_PRETTY_PRINT,
                                      &json_string);
   return Value::CreateStringValue(json_string);

[Joao da Silva, 2012/08/09 09:24:52]

Nit: base::

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

 }
 
 // static
-void NetworkConfigurationPolicyHandler::StripSensitiveValues(
+void NetworkConfigurationPolicyHandler::MaskSensitiveValues(
     DictionaryValue* network_dict) {

[Joao da Silva, 2012/08/09 09:24:52]

Nit: base::

[Mattias Nissler (ping if slow), 2012/08/09 11:32:42]

Done.

-  // List of settings we filter from the network dictionary.
-  static const char* kFilteredSettings[] = {
-    "WiFi.Passphrase",
-    "IPsec.EAP.Password",
-    "IPsec.EAP.Password",
-    "IPsec.XAUTH.Password",
-    "L2TP.Password",
+  // Paths of the properties to be replaced by the placeholder. Each entry
+  // specifies dictionary key paths and must be terminated by a NULL element.
+  static const int kMaxComponents = 4;
+  static const char* kFilteredSettings[][kMaxComponents] = {
+    { onc::kEthernet, onc::ethernet::kEAP, onc::eap::kPassword },
+    { onc::kVPN, onc::vpn::kIPsec, onc::vpn::kPSK },
+    { onc::kVPN, onc::vpn::kL2TP, onc::vpn::kPassword },
+    { onc::kVPN, onc::vpn::kOpenVPN, onc::vpn::kPassword },
+    { onc::kWiFi, onc::wifi::kEAP, onc::eap::kPassword },
+    { onc::kWiFi, onc::wifi::kPassphrase },
   };
+
   // Placeholder to insert in place of the filtered setting.
   static const char kPlaceholder[] = "********";
 
   for (size_t i = 0; i < arraysize(kFilteredSettings); ++i) {
-    if (network_dict->Remove(kFilteredSettings[i], NULL)) {
-      network_dict->Set(kFilteredSettings[i],
-                        Value::CreateStringValue(kPlaceholder));
+    const char** path = kFilteredSettings[i];
+    base::DictionaryValue* dict = network_dict;
+    int j = 0;
+    for (j = 0; path[j + 1] != NULL; ++j) {
+      if (!dict->GetDictionaryWithoutPathExpansion(path[j], &dict)) {
+        dict = NULL;
+        break;
+      }
+    }
+    if (dict && dict->RemoveWithoutPathExpansion(path[j], NULL)) {
+      dict->SetWithoutPathExpansion(
+          path[j], base::Value::CreateStringValue(kPlaceholder));
     }
   }
 }
 
 PinnedLauncherAppsPolicyHandler::PinnedLauncherAppsPolicyHandler()
     : ExtensionListPolicyHandler(key::kPinnedLauncherApps,
                                  prefs::kPinnedLauncherApps,
                                  false) {}
 
 PinnedLauncherAppsPolicyHandler::~PinnedLauncherAppsPolicyHandler() {}
@@ skipping 13 matching lines @@
         base::DictionaryValue* app_dict = new base::DictionaryValue();
         app_dict->SetString(ash::kPinnedAppsPrefAppIDPath, id);
         pinned_apps_list->Append(app_dict);
       }
     }
     prefs->SetValue(pref_path(), pinned_apps_list);
   }
 }
 
 }  // namespace policy