chrome/browser/debugger/devtools_window.h - Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/debugger/devtools_window.h

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Return NULL as the ToggleDevToolsWindow() result for DevTools windows Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/debugger/devtools_toggle_action.h ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | chrome/browser/debugger/devtools_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/debugger/devtools_window.h

diff --git a/chrome/browser/debugger/devtools_window.h b/chrome/browser/debugger/devtools_window.h

index dfe73ab8d141e5e3d995312c72c30f54dd1a1197..2a8dcbc7090aca7138137a34f76a5769fc784fe8 100644

--- a/chrome/browser/debugger/devtools_window.h

+++ b/chrome/browser/debugger/devtools_window.h

@@ -57,7 +57,7 @@ class DevToolsWindow : private content::NotificationObserver,

static DevToolsWindow* OpenDevToolsWindow(

content::RenderViewHost* inspected_rvh);

static DevToolsWindow* ToggleDevToolsWindow(

- content::RenderViewHost* inspected_rvh,

+ Browser* browser,

DevToolsToggleAction action);

static void InspectElement(

content::RenderViewHost* inspected_rvh, int x, int y);

@@ -134,6 +134,7 @@ class DevToolsWindow : private content::NotificationObserver,

bool force_open,

DevToolsToggleAction action);

static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*);

+ static DevToolsWindow* AsDevToolsWindow(content::RenderViewHost*);

// content::DevToolsClientHandlerDelegate overrides.

virtual void ActivateWindow() OVERRIDE;