Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/debugger/devtools_window.h

Issue 10823233: Close detached DevTools window (rather than open a new instance) when it receives an F12 keypress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 content::WebContents* web_contents, 127 content::WebContents* web_contents,
128 const content::FileChooserParams& params) OVERRIDE; 128 const content::FileChooserParams& params) OVERRIDE;
129 129
130 virtual void FrameNavigating(const std::string& url) OVERRIDE {} 130 virtual void FrameNavigating(const std::string& url) OVERRIDE {}
131 131
132 static DevToolsWindow* ToggleDevToolsWindow( 132 static DevToolsWindow* ToggleDevToolsWindow(
133 content::RenderViewHost* inspected_rvh, 133 content::RenderViewHost* inspected_rvh,
134 bool force_open, 134 bool force_open,
135 DevToolsToggleAction action); 135 DevToolsToggleAction action);
136 static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*); 136 static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*);
137 static DevToolsWindow* AsDevToolsWindow(content::RenderViewHost*);
pfeldman 2012/08/14 11:04:11 You don't need this.
137 138
138 // content::DevToolsClientHandlerDelegate overrides. 139 // content::DevToolsClientHandlerDelegate overrides.
139 virtual void ActivateWindow() OVERRIDE; 140 virtual void ActivateWindow() OVERRIDE;
140 virtual void CloseWindow() OVERRIDE; 141 virtual void CloseWindow() OVERRIDE;
141 virtual void MoveWindow(int x, int y) OVERRIDE; 142 virtual void MoveWindow(int x, int y) OVERRIDE;
142 virtual void DockWindow() OVERRIDE; 143 virtual void DockWindow() OVERRIDE;
143 virtual void UndockWindow() OVERRIDE; 144 virtual void UndockWindow() OVERRIDE;
144 virtual void SetDockSide(const std::string& side) OVERRIDE; 145 virtual void SetDockSide(const std::string& side) OVERRIDE;
145 virtual void OpenInNewTab(const std::string& url) OVERRIDE; 146 virtual void OpenInNewTab(const std::string& url) OVERRIDE;
146 virtual void SaveToFile(const std::string& url, 147 virtual void SaveToFile(const std::string& url,
(...skipping 17 matching lines...) Expand all
164 bool docked_; 165 bool docked_;
165 bool is_loaded_; 166 bool is_loaded_;
166 DevToolsToggleAction action_on_load_; 167 DevToolsToggleAction action_on_load_;
167 content::NotificationRegistrar registrar_; 168 content::NotificationRegistrar registrar_;
168 content::DevToolsClientHost* frontend_host_; 169 content::DevToolsClientHost* frontend_host_;
169 scoped_ptr<DevToolsFileHelper> file_helper_; 170 scoped_ptr<DevToolsFileHelper> file_helper_;
170 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 171 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
171 }; 172 };
172 173
173 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 174 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698