Inline media::Pipeline::ResetState() into initializer list.

Inline media::Pipeline::ResetState() into initializer list.

The method gives the illusion that Pipeline objects can be reset to the initial state. They can't.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150590

[scherkus (not reviewing), 2012-08-08 01:04:07]

split off from http://codereview.chromium.org/10828045/

[scherkus (not reviewing), 2012-08-08 01:05:30]

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline.cc
File media/base/pipeline.cc (right):

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:20: #include "media/base/buffers.h"
for kNoTimestamp() which surprisingly enough isn't used elsewhere in this file!

[acolwell GONE FROM CHROMIUM, 2012-08-08 17:17:28]

LGTM

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline.cc
File media/base/pipeline.cc (right):

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:73: seek_pending_(false),
This is probably best left for a different CL, but seek_pending_ & stop_pending_
might be redundant with !seek_cb_.is_null() && !stop_cb_.is_null().

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:317: ReportStatus(seek_cb_, status_);
seek_timestamp_ = kNoTimestamp()?

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:910: clock_->SetTime(seek_timestamp_, seek_timestamp_);
DCHECK(seek_timestamp_ != kNoTimestamp());

[scherkus (not reviewing), 2012-08-08 17:26:59]

thanks!

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline.cc
File media/base/pipeline.cc (right):

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:73: seek_pending_(false),
On 2012/08/08 17:17:28, acolwell wrote:
> This is probably best left for a different CL, but seek_pending_ &
stop_pending_
> might be redundant with !seek_cb_.is_null() && !stop_cb_.is_null().

Yeah I have parts of that done in my yet-to-be-fully-realized CL

AFAIK stop_pending_ *is* the same as stop_cb_ but seek_pending_ *is not* the
same as seek_cb_ since seek_cb_ might be the callback passed to Start()

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:317: ReportStatus(seek_cb_, status_);
On 2012/08/08 17:17:28, acolwell wrote:
> seek_timestamp_ = kNoTimestamp()?

Done.

https://chromiumcodereview.appspot.com/10823222/diff/3001/media/base/pipeline...
media/base/pipeline.cc:910: clock_->SetTime(seek_timestamp_, seek_timestamp_);
On 2012/08/08 17:17:28, acolwell wrote:
> DCHECK(seek_timestamp_ != kNoTimestamp());

Done.

[commit-bot: I haz the power, 2012-08-08 17:27:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/10823222/7001