Create/Delete windows profile shortcuts

chrome/browser/profiles/avatar_menu_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/avatar_menu_model.h"
 
 #include "base/bind.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/avatar_menu_model_observer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_info_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
@@ skipping 75 matching lines @@
         profile_info_->GetPathOfProfileAtIndex(GetItemAt(index).model_index));
     browser = new Browser(Browser::CreateParams(profile));
   }
   std::string page = chrome::kManageProfileSubPage;
   page += "#";
   page += base::IntToString(static_cast<int>(index));
   chrome::ShowSettingsSubPage(browser, page);
 }
 
 void AvatarMenuModel::AddNewProfile() {
-  ProfileManager::CreateMultiProfileAsync(string16(), string16());
+  // Temporarily generate a random icon/name pair to create the profile with

[sail, 2012/08/10 18:01:14]

This will break creating a new profile.

Do you really need to check this in?

[Halli, 2012/08/13 21:50:10]

Shortcuts can't be generated from the avatar menu without this. But other than
that it's fine to not be checked in. I can still create new profiles with this
code, I think it follows the same path as when you create from the Create Dialog
as if you accepted the randomized avatar/name choice. Does this affect the
logging/cache in some way?
On 2012/08/10 18:01:14, sail wrote:

[sail, 2012/08/13 22:09:36]

Yea, if you really need this then you should just do
ProfileShortcutManager::IsFeatureEnabled().

[Halli, 2012/08/14 18:25:57]

Done.

+  // instead of opening a dialog for creating a profile
+  // Remove on completion of BUG 134904
+  ProfileManager* profile_manager = g_browser_process->profile_manager();
+  ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
+  size_t icon_index = cache.ChooseAvatarIconIndexForNewProfile();
+
+  g_browser_process->profile_manager()->CreateMultiProfileAsync(
+      cache.ChooseNameForNewProfile(icon_index),
+      ASCIIToUTF16(cache.GetDefaultAvatarIconUrl(icon_index)));
   ProfileMetrics::LogProfileAddNewUser(ProfileMetrics::ADD_NEW_USER_ICON);
 }
 
 size_t AvatarMenuModel::GetNumberOfItems() {
   return items_.size();
 }
 
 size_t AvatarMenuModel::GetActiveProfileIndex() {
   // During singleton profile deletion, this function can be called with no
   // profiles in the model - crbug.com/102278 .
@@ skipping 57 matching lines @@
       item->active = browser_->profile()->GetPath() == path;
     }
     items_.push_back(item);
   }
 }
 
 void AvatarMenuModel::ClearMenu() {
   STLDeleteContainerPointers(items_.begin(), items_.end());
   items_.clear();
 }