Create/Delete windows profile shortcuts

chrome/browser/profiles/profile_shortcut_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_H_
+#define CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_H_
+
+#include "base/file_path.h"
+#include "ui/gfx/image/image.h"
+
+class ProfileShortcutManager {
+ public:
+  static bool IsFeatureEnabled();
+  static ProfileShortcutManager* Create();
+
+  ProfileShortcutManager();

[Ben Goodger (Google), 2012/08/14 22:43:19]

This class looks a lot like an interface. As such it's a bit unusual to have a
constructor here, especially since you can never make one of these publicly via
this ctor (you have to use Create() to make the right impl).

I would remove this ctor. If you ever need to initialize state shared by cross
platform subclasses, you can add a protected ctor later.

[Halli, 2012/08/15 18:13:53]

I get the following error when I remove the constructor:
146>browser\profiles\profile_shortcut_manager_win.cc(172): error C2512:
'ProfileShortcutManager' : no appropriate default constructor available

On 2012/08/14 22:43:19, Ben Goodger (Google) wrote:

+  ~ProfileShortcutManager();

[Ben Goodger (Google), 2012/08/14 22:43:19]

Constructors and destructors should be listed before the static methods above.

[Halli, 2012/08/15 18:13:53]

Done.

+
+  virtual void CreateChromeDesktopShortcut(
+      const FilePath& profile_path, const string16& profile_name,
+      const gfx::Image& avatar_image) = 0;
+  virtual void DeleteChromeDesktopShortcut(const FilePath& profile_path) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ProfileShortcutManager);
+};
+
+#endif  // CHROME_BROWSER_PROFILES_PROFILE_SHORTCUT_MANAGER_H_