Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 10823207: Consolidate ContentViewCore::Load* functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@cleanup_load
Patch Set: Rebase. Add extra_headers to LoadUrlParams. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 34cc48f66f00fd70ba91992cf07cc4b26cfc35ff..a8777693b01bc571afe66fe85080c8cadb301687 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -364,40 +364,19 @@ public class ContentViewCore implements MotionEventDelegate {
* ensuring the URL passed in is properly formatted (i.e. the scheme has been added if left
* off during user input).
*
- * @param url The url to load.
+ * @param pararms Parameters for this load.
*/
- public void loadUrlWithoutUrlSanitization(String url) {
- loadUrlWithoutUrlSanitization(url, PAGE_TRANSITION_TYPED);
- }
-
- /**
- * Load url without fixing up the url string. Consumers of ContentView are responsible for
- * ensuring the URL passed in is properly formatted (i.e. the scheme has been added if left
- * off during user input).
- *
- * @param url The url to load.
- * @param pageTransition Page transition id that describes the action that led to this
- * navigation. It is important for ranking URLs in the history so the
- * omnibox can report suggestions correctly.
- */
- public void loadUrlWithoutUrlSanitization(String url, int pageTransition) {
- mAccessibilityInjector.addOrRemoveAccessibilityApisIfNecessary();
- if (mNativeContentViewCore != 0) {
- if (isPersonalityView()) {
- nativeLoadUrlWithoutUrlSanitizationWithUserAgentOverride(
- mNativeContentViewCore,
- url,
- pageTransition,
- mContentSettings.getUserAgentString());
- } else {
- // Chrome stores overridden UA strings in navigation history
- // items, so they stay the same on going back / forward.
- nativeLoadUrlWithoutUrlSanitization(
- mNativeContentViewCore,
- url,
- pageTransition);
- }
- }
+ public void loadUrl(LoadUrlParams params) {
+ if (mNativeContentViewCore == 0) return;
+ nativeLoadUrl(mNativeContentViewCore,
+ params.mUrl,
+ params.mLoadUrlType,
+ params.mTransitionType,
+ params.mUaOverrideOption,
+ params.mExtraHeaders,
+ params.mPostData,
+ params.mBaseUrlForDataUrl,
+ params.mVirtualUrlForDataUrl);
}
void setAllUserAgentOverridesInHistory() {
@@ -1144,11 +1123,16 @@ public class ContentViewCore implements MotionEventDelegate {
private static native void nativeDestroy(int nativeContentViewCoreImpl);
- private native void nativeLoadUrlWithoutUrlSanitization(int nativeContentViewCoreImpl,
- String url, int pageTransition);
- private native void nativeLoadUrlWithoutUrlSanitizationWithUserAgentOverride(
- int nativeContentViewCoreImpl, String url, int pageTransition,
- String userAgentOverride);
+ private native void nativeLoadUrl(
+ int nativeContentViewCoreImpl,
+ String url,
+ int loadUrlType,
+ int transitionType,
+ int uaOverrideOption,
+ String extraHeaders,
+ byte[] postData,
+ String baseUrlForDataUrl,
+ String virtualUrlForDataUrl);
private native String nativeGetURL(int nativeContentViewCoreImpl);

Powered by Google App Engine
This is Rietveld 408576698