Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 10823207: Consolidate ContentViewCore::Load* functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@cleanup_load
Patch Set: address Charlie's comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentView.java b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
index 24aaf9f0975e51784c6d5511ed4102922cd02fdb..a16d3899789f8122e98d0803772c72e66335c120 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentView.java
@@ -212,24 +212,10 @@ public class ContentView extends FrameLayout implements ContentViewCore.Internal
* ensuring the URL passed in is properly formatted (i.e. the scheme has been added if left
* off during user input).
*
- * @param url The url to load.
+ * @param pararms Parameters for this load.
*/
- public void loadUrlWithoutUrlSanitization(String url) {
- loadUrlWithoutUrlSanitization(url, PAGE_TRANSITION_TYPED);
- }
-
- /**
- * Load url without fixing up the url string. Consumers of ContentView are responsible for
- * ensuring the URL passed in is properly formatted (i.e. the scheme has been added if left
- * off during user input).
- *
- * @param url The url to load.
- * @param pageTransition Page transition id that describes the action that led to this
- * navigation. It is important for ranking URLs in the history so the
- * omnibox can report suggestions correctly.
- */
- public void loadUrlWithoutUrlSanitization(String url, int pageTransition) {
- mContentViewCore.loadUrlWithoutUrlSanitization(url, pageTransition);
+ public void loadUrl(LoadUrlParams params) {
+ mContentViewCore.loadUrl(params);
}
void setAllUserAgentOverridesInHistory() {

Powered by Google App Engine
This is Rietveld 408576698