Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: content/public/android/java/src/org/chromium/content/browser/ContentView.java

Issue 10823207: Consolidate ContentViewCore::Load* functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@cleanup_load
Patch Set: Rebase. Add extra_headers to LoadUrlParams. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.content.res.Configuration; 8 import android.content.res.Configuration;
9 import android.graphics.Canvas; 9 import android.graphics.Canvas;
10 import android.os.Build; 10 import android.os.Build;
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 201
202 ContentViewClient getContentViewClient() { 202 ContentViewClient getContentViewClient() {
203 return mContentViewCore.getContentViewClient(); 203 return mContentViewCore.getContentViewClient();
204 } 204 }
205 205
206 /** 206 /**
207 * Load url without fixing up the url string. Consumers of ContentView are r esponsible for 207 * Load url without fixing up the url string. Consumers of ContentView are r esponsible for
208 * ensuring the URL passed in is properly formatted (i.e. the scheme has bee n added if left 208 * ensuring the URL passed in is properly formatted (i.e. the scheme has bee n added if left
209 * off during user input). 209 * off during user input).
210 * 210 *
211 * @param url The url to load. 211 * @param pararms Parameters for this load.
212 */ 212 */
213 public void loadUrlWithoutUrlSanitization(String url) { 213 public void loadUrl(LoadUrlParams params) {
214 loadUrlWithoutUrlSanitization(url, PAGE_TRANSITION_TYPED); 214 mContentViewCore.loadUrl(params);
215 }
216
217 /**
218 * Load url without fixing up the url string. Consumers of ContentView are r esponsible for
219 * ensuring the URL passed in is properly formatted (i.e. the scheme has bee n added if left
220 * off during user input).
221 *
222 * @param url The url to load.
223 * @param pageTransition Page transition id that describes the action that l ed to this
224 * navigation. It is important for ranking URLs in the history so the
225 * omnibox can report suggestions correctly.
226 */
227 public void loadUrlWithoutUrlSanitization(String url, int pageTransition) {
228 mContentViewCore.loadUrlWithoutUrlSanitization(url, pageTransition);
229 } 215 }
230 216
231 void setAllUserAgentOverridesInHistory() { 217 void setAllUserAgentOverridesInHistory() {
232 mContentViewCore.setAllUserAgentOverridesInHistory(); 218 mContentViewCore.setAllUserAgentOverridesInHistory();
233 } 219 }
234 220
235 /** 221 /**
236 * Stops loading the current web contents. 222 * Stops loading the current web contents.
237 */ 223 */
238 public void stopLoading() { 224 public void stopLoading() {
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
599 585
600 @Override 586 @Override
601 public boolean super_awakenScrollBars(int startDelay, boolean invalidate) { 587 public boolean super_awakenScrollBars(int startDelay, boolean invalidate) {
602 return super.awakenScrollBars(startDelay, invalidate); 588 return super.awakenScrollBars(startDelay, invalidate);
603 } 589 }
604 590
605 //////////////////////////////////////////////////////////////////////////// /////////////////// 591 //////////////////////////////////////////////////////////////////////////// ///////////////////
606 // End Implementation of ContentViewCore.InternalAccessDelega te // 592 // End Implementation of ContentViewCore.InternalAccessDelega te //
607 //////////////////////////////////////////////////////////////////////////// /////////////////// 593 //////////////////////////////////////////////////////////////////////////// ///////////////////
608 } 594 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698