Fix downloads db state=3 corruption using version=23

chrome/browser/history/history_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // History unit tests come in two flavors:
 //
 // 1. The more complicated style is that the unit test creates a full history
 //    service. This spawns a background thread for the history backend, and
 //    all communication is asynchronous. This is useful for testing more
 //    complicated things or end-to-end behavior.
@@ skipping 24 matching lines @@
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/history/history.h"
 #include "chrome/browser/history/history_backend.h"
 #include "chrome/browser/history/history_database.h"
 #include "chrome/browser/history/history_notifications.h"
 #include "chrome/browser/history/in_memory_database.h"
 #include "chrome/browser/history/in_memory_history_backend.h"
 #include "chrome/browser/history/page_usage_data.h"
+#include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/thumbnail_score.h"
 #include "chrome/tools/profiles/thumbnail-inl.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_persistent_store_info.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_source.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 123 matching lines @@
     history_service_->Cleanup();
     history_service_ = NULL;
 
     // Wait for the backend class to terminate before deleting the files and
     // moving to the next test. Note: if this never terminates, somebody is
     // probably leaking a reference to the history backend, so it never calls
     // our destroy task.
     MessageLoop::current()->Run();
   }
 
-  int64 AddDownload(int32 state, const Time& time) {
+  int64 AddDownload(DownloadItem::DownloadState state, const Time& time) {
     DownloadPersistentStoreInfo download(
         FilePath(FILE_PATH_LITERAL("foo-path")),
         GURL("foo-url"),
         GURL(""),
         time,
         time,
         0,
         512,
         state,
         0,
@@ skipping 117 matching lines @@
   Time now = Time::Now();
   TimeDelta one_day = TimeDelta::FromDays(1);
   Time month_ago = now - TimeDelta::FromDays(30);
 
   // Initially there should be nothing in the downloads database.
   std::vector<DownloadPersistentStoreInfo> downloads;
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(0U, downloads.size());
 
   // Keep track of these as we need to update them later during the test.
-  DownloadID in_progress, removing;
+  DownloadID in_progress;
 
   // Create one with a 0 time.
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE, Time()));
   // Create one for now and +/- 1 day.
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE, now - one_day));
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE, now));
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE, now + one_day));
   // Try the other four states.
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE, month_ago));
   EXPECT_NE(0, in_progress = AddDownload(DownloadItem::IN_PROGRESS, month_ago));
   EXPECT_NE(0, AddDownload(DownloadItem::CANCELLED, month_ago));
   EXPECT_NE(0, AddDownload(DownloadItem::INTERRUPTED, month_ago));
-  EXPECT_NE(0, removing = AddDownload(DownloadItem::REMOVING, month_ago));
+  EXPECT_EQ(0, AddDownload(DownloadItem::REMOVING, month_ago));
 
   // Test to see if inserts worked.
   db_->QueryDownloads(&downloads);
-  EXPECT_EQ(9U, downloads.size());
+  EXPECT_EQ(8U, downloads.size());
 
   // Try removing from current timestamp. This should delete the one in the
   // future and one very recent one.
   db_->RemoveDownloadsBetween(now, Time());
   db_->QueryDownloads(&downloads);
-  EXPECT_EQ(7U, downloads.size());
+  EXPECT_EQ(6U, downloads.size());
 
   // Try removing from two months ago. This should not delete items that are
   // 'in progress' or in 'removing' state.
   db_->RemoveDownloadsBetween(now - TimeDelta::FromDays(60), Time());
   db_->QueryDownloads(&downloads);
-  EXPECT_EQ(3U, downloads.size());
+  EXPECT_EQ(2U, downloads.size());
 
   // Download manager converts to TimeT, which is lossy, so we do the same
   // for comparison.
   Time month_ago_lossy = Time::FromTimeT(month_ago.ToTimeT());
 
   // Make sure the right values remain.
   EXPECT_EQ(DownloadItem::COMPLETE, downloads[0].state);
   EXPECT_EQ(0, downloads[0].start_time.ToInternalValue());
   EXPECT_EQ(DownloadItem::IN_PROGRESS, downloads[1].state);
   EXPECT_EQ(month_ago_lossy.ToInternalValue(),
             downloads[1].start_time.ToInternalValue());
-  EXPECT_EQ(DownloadItem::REMOVING, downloads[2].state);
-  EXPECT_EQ(month_ago_lossy.ToInternalValue(),
-            downloads[2].start_time.ToInternalValue());
 
   // Change state so we can delete the downloads.
   DownloadPersistentStoreInfo data;
   data.received_bytes = 512;
   data.state = DownloadItem::COMPLETE;
   data.end_time = base::Time::Now();
   data.opened = false;
   data.db_handle = in_progress;
   EXPECT_TRUE(db_->UpdateDownload(data));
-  data.state = DownloadItem::CANCELLED;
-  data.db_handle = removing;
-  EXPECT_TRUE(db_->UpdateDownload(data));
 
   // Try removing from Time=0. This should delete all.
   db_->RemoveDownloadsBetween(Time(), Time());
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(0U, downloads.size());
 
   // Check removal of downloads stuck in IN_PROGRESS state.
   EXPECT_NE(0, AddDownload(DownloadItem::COMPLETE,    month_ago));
   EXPECT_NE(0, AddDownload(DownloadItem::IN_PROGRESS, month_ago));
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(2U, downloads.size());
   db_->RemoveDownloadsBetween(Time(), Time());
   db_->QueryDownloads(&downloads);
   // IN_PROGRESS download should remain. It it indicated as "Canceled"
   EXPECT_EQ(1U, downloads.size());
   db_->CleanUpInProgressEntries();
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(1U, downloads.size());
   db_->RemoveDownloadsBetween(Time(), Time());
   db_->QueryDownloads(&downloads);
   EXPECT_EQ(0U, downloads.size());
 }
 
+TEST_F(HistoryTest, MigrateDownloadsState) {
+  // Create the db and close it so that we can reopen it directly.
+  CreateBackendAndDatabase();
+  DeleteBackend();
+  {
+    // Re-open the db for manual manipulation.
+    sql::Connection db;
+    ASSERT_TRUE(db.Open(history_dir_.Append(chrome::kHistoryFilename)));
+    {
+      // Manually force the version to 22.
+      sql::Statement version22(db.GetUniqueStatement(
+            "UPDATE meta SET value=22 WHERE key='version'"));
+      ASSERT_TRUE(version22.Run());
+    }
+    // Manually insert corrupted rows; there's infrastructure in place now to
+    // make this impossible, at least according to the test above.
+    for (int state = 0; state < 5; ++state) {
+      sql::Statement s(db.GetUniqueStatement(
+            "INSERT INTO downloads (id, full_path, url, start_time, "
+            "received_bytes, total_bytes, state, end_time, opened) VALUES "
+            "(?, ?, ?, ?, ?, ?, ?, ?, ?)"));
+      s.BindInt64(0, 1 + state);
+      s.BindString(1, "path");
+      s.BindString(2, "url");
+      s.BindInt64(3, base::Time::Now().ToTimeT());
+      s.BindInt64(4, 100);
+      s.BindInt64(5, 100);
+      s.BindInt(6, state);
+      s.BindInt64(7, base::Time::Now().ToTimeT());
+      s.BindInt(8, state % 2);
+      ASSERT_TRUE(s.Run());
+    }
+  }
+
+  // Re-open the db using the HistoryDatabase, which should migrate from version
+  // 22 to 23, fixing just the row whose state was 3. Then close the db so that
+  // we can re-open it directly.
+  CreateBackendAndDatabase();
+  DeleteBackend();
+  {
+    // Re-open the db for manual manipulation.
+    sql::Connection db;
+    ASSERT_TRUE(db.Open(history_dir_.Append(chrome::kHistoryFilename)));
+    {
+      // The version should have been updated.
+      int cur_version = HistoryDatabase::GetCurrentVersion();
+      ASSERT_LT(22, cur_version);
+      sql::Statement s(db.GetUniqueStatement(
+          "SELECT value FROM meta WHERE key = 'version'"));
+      EXPECT_TRUE(s.Step());
+      EXPECT_EQ(cur_version, s.ColumnInt(0));
+    }
+    {
+      sql::Statement statement(db.GetUniqueStatement(
+          "SELECT id, state, opened "
+          "FROM downloads "
+          "ORDER BY id"));
+      int counter = 0;
+      while (statement.Step()) {
+        EXPECT_EQ(1 + counter, statement.ColumnInt64(0));
+        // The only thing that migration should have changed was state from 3 to
+        // 4.
+        EXPECT_EQ(((counter == 3) ? 4 : counter), statement.ColumnInt(1));
+        EXPECT_EQ(counter % 2, statement.ColumnInt(2));
+        ++counter;
+      }
+      EXPECT_EQ(5, counter);
+    }
+  }
+}
+
 TEST_F(HistoryTest, AddPage) {
   scoped_refptr<HistoryService> history(new HistoryService);
   history_service_ = history;
   ASSERT_TRUE(history->Init(history_dir_, NULL));
 
   // Add the page once from a child frame.
   const GURL test_url("http://www.google.com/");
   history->AddPage(test_url, NULL, 0, GURL(),
                    content::PAGE_TRANSITION_MANUAL_SUBFRAME,
                    history::RedirectList(),
@@ skipping 541 matching lines @@
   history_service_ = history;
   history->ScheduleDBTask(task.get(), &request_consumer);
   request_consumer.CancelAllRequests();
   CleanupHistoryService();
   // WARNING: history has now been deleted.
   history = NULL;
   ASSERT_FALSE(task->done_invoked);
 }
 
 }  // namespace history