While dragging a window, show a semi-transparent aura window instead of the standard gray phantom wi

ash/wm/workspace/workspace_window_resizer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 #define ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 
 #include <vector>
 
 #include "ash/wm/window_resizer.h"
@@ skipping 34 matching lines @@
       int window_component,
       const std::vector<aura::Window*>& attached_windows);
 
   // Returns true if the drag will result in changing the window in anyway.
   bool is_resizable() const { return details_.is_resizable; }
 
   const gfx::Point& initial_location_in_parent() const {
     return details_.initial_location_in_parent;
   }
 
+  PhantomWindowController* snap_phantom_window_controller_for_testing() const {

[sky, 2012/08/09 21:57:27]

Instead of this, make the test a friend. Or create a class that is only compiled
during tests that is a friend.

[Yusuke Sato, 2012/08/10 00:30:49]

Done.

+    return snap_phantom_window_controller_.get();
+  }
+
+  PhantomWindowController* drag_phantom_window_controller_for_testing() const {
+    return drag_phantom_window_controller_.get();
+  }
+
   // Overridden from WindowResizer:
   virtual void Drag(const gfx::Point& location, int event_flags) OVERRIDE;
   virtual void CompleteDrag(int event_flags) OVERRIDE;
   virtual void RevertDrag() OVERRIDE;
 
  private:
   WorkspaceWindowResizer(const Details& details,
                          const std::vector<aura::Window*>& attached_windows);
 
  private:
@@ skipping 43 matching lines @@
   // left/right multi window resize and top/bottom resize.
   int PrimaryAxisSize(const gfx::Size& size) const;
   int PrimaryAxisCoordinate(int x, int y) const;
 
   // Updates the bounds of the phantom window for window snapping.
   void UpdateSnapPhantomWindow(const gfx::Point& location,
                                const gfx::Rect& bounds,
                                int grid_size);
 
   // Updates the bounds of the phantom window for window dragging.
-  void UpdateDragPhantomWindow(const gfx::Rect& bounds);
+  void UpdateDragPhantomWindow(const gfx::Rect& bounds, bool in_original_root);

[sky, 2012/08/09 21:57:27]

Document |in_original_root|.

[Yusuke Sato, 2012/08/10 00:30:49]

Done.

 
   // Restacks the windows z-order position so that one of the windows is at the
   // top of the z-order, and the rest directly underneath it.
   void RestackWindows();
 
   // Returns the SnapType for the specified point. SNAP_NONE is used if no
   // snapping should be used.
   SnapType GetSnapType(const gfx::Point& location) const;
 
   // Returns true if we should allow the mouse pointer to warp.
@@ skipping 29 matching lines @@
   // Sum of sizes in |min_size_|.
   int total_min_;
 
   // Sum of the sizes in |initial_size_|.
   int total_initial_size_;
 
   // Gives a previews of where the the window will end up. Only used if there
   // is a grid and the caption is being dragged.
   scoped_ptr<PhantomWindowController> snap_phantom_window_controller_;
 
-  // For now, we show a phantom window on the other root window during dragging.
-  // TODO(yusukes): Show a semi-transparent image (screen shot) of the window
-  // instead.
+  // Shows a semi-transparent image of the window being dragged.
   scoped_ptr<PhantomWindowController> drag_phantom_window_controller_;
 
   // Used to determine the target position of a snap.
   scoped_ptr<SnapSizer> snap_sizer_;
 
   // Last SnapType.
   SnapType snap_type_;
 
   // Number of mouse moves since the last bounds change. Only used for phantom
   // placement to track when the mouse is moved while pushed against the edge of
   // the screen.
   int num_mouse_moves_since_bounds_change_;
 
   // The mouse location passed to Drag().
   gfx::Point last_mouse_location_;
 
   DISALLOW_COPY_AND_ASSIGN(WorkspaceWindowResizer);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_WM_WORKSPACE_WINDOW_RESIZER_H_